Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translatable string and missing date on reconciliation overview #1580

Closed
lucavallerini opened this issue Jul 30, 2018 · 3 comments
Closed
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@lucavallerini
Copy link
Contributor

I am running Firefly III version 4.7.5.3

As you can see in the image below, the title of the dialog is in English and I cannot find that string on Crowdin.
reconciliation

Also, in the first and fourth line (Start/End balance submitted), between parenthesis there should be an actual date, right?

JC5 added a commit that referenced this issue Jul 31, 2018
@JC5
Copy link
Member

JC5 commented Jul 31, 2018

Ah thanks for letting me know, I didn't realise! I've pushed a fix that will be included in the next release, and the new translation should be available in Crowdin now. 👍

@lucavallerini
Copy link
Contributor Author

Thank you! In the meantime I applied the fix to my installation.

I translated the new string(s) on Crowdin too.

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Jul 31, 2018
@lucavallerini lucavallerini changed the title Missing translatable string Missing translatable string and missing date on reconciliation overview Jul 31, 2018
@JC5 JC5 added this to 4.7.6 in Firefly III roadmap Aug 5, 2018
@JC5
Copy link
Member

JC5 commented Aug 7, 2018

I'm closing this since it's fixed. Look for this feature in the next release, and let me know if you encounter any problems!

@JC5 JC5 closed this as completed Aug 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants