Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing transaction type doesn't count as update (and don't fire update rules) #1679

Closed
hamuz opened this issue Sep 13, 2018 · 2 comments
Closed
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@hamuz
Copy link
Contributor

hamuz commented Sep 13, 2018

Bug description
I am running Firefly III version 4.7.6.2

Changing transaction type doesn't count as update (and don't fire update rules)

Steps to reproduce
What do you need to do to trigger this bug?

  1. Create rule to match test transaction on update (with set destination account action, for example)
  2. Create withdrawal
  3. Convert to transfer (rule doesn't run)

Questions
Does transaction creation also count as update? (as far as firing rules goes)

@JC5
Copy link
Member

JC5 commented Sep 13, 2018

Indeed. That action isn't covered. I will add some code to remedy. Never thought to add it.

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Sep 13, 2018
JC5 added a commit that referenced this issue Sep 13, 2018
@JC5 JC5 added this to 4.7.7 in Firefly III roadmap Sep 13, 2018
@hamuz
Copy link
Contributor Author

hamuz commented Sep 14, 2018

I guess this one is sort-of fixed, but look at #1689.

@hamuz hamuz closed this as completed Sep 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants