Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User seemingly can modify a grayed out field of a split transaction #2553

Closed
GeoffreyFrogeye opened this issue Sep 7, 2019 · 1 comment
Closed
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).

Comments

@GeoffreyFrogeye
Copy link
Contributor

GeoffreyFrogeye commented Sep 7, 2019

Bug description
I am running Firefly III version f36b369, and my problem is:

When you edit a split transaction, the source (resp. destination) field for a withdrawal (resp. deposit) is not greyed out, and changing it won't be taked into account, despite being shown no error message / warning. This may possibly lead the user in error that the changes were correctly applied.

Steps to reproduce

Create a split transaction, here a withdrawal.

2019-09-07-091942_1920x1080_scrot

We can see that the source field is grayed out, as it shouldn't be different from the first one.

2019-09-07-091950_1920x1080_scrot

Save it, then open it again to edit it.

2019-09-07-092035_1665x1052_scrot

Here, the field is no longer grayed out. We can change it, and the suggestions also work.

2019-09-07-092049_1669x1073_scrot

Saving it will discard the source changes, without any warning or error.

2019-09-07-092108_1675x459_scrot

Expected behavior

The field being grayed out and an error message if the user tries to change the field instead of silently discarding it (for the API of course).

Extra info

I don't understand why this is a restriction in the first place. Paying for something with multiple sources (credit card, cash, check, meal vouchers... The screenshots I took gave an example) sounds like a reasonable use case, and I don't think it's really suited for linked transactions either.

@JC5
Copy link
Member

JC5 commented Sep 7, 2019

There is no technical restriction but I want to keep this simple. In Firefly III, a withdrawal has one source and multiple destinations. A deposit has one destination with multiple sources. A transfer, even a split one, has one source and one destination.

I know there are plenty of use cases to be thought of where this isn't the case (you list some excellent ones) but supporting every edge case is explicitly not the goal of Firefly III. That's something that fits better with GNUCash.

I am aware that there are some cases where the proper fields are not greyed out. I'll pick it up as an enhancement and try to fix it for the next release.

My experience so far has been that only advanced users run into the problems you describe and they know where to find me.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Sep 7, 2019
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Sep 7, 2019
@JC5 JC5 closed this as completed in cb7a4fe Sep 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants