Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Dockerfile for base image for jc5x/firefly-iii nowhere to be found #2655

Closed
michael-v2vlc opened this issue Sep 24, 2019 · 4 comments
Labels
stale No replies or comments. Will be auto-closed in 14 days.

Comments

@michael-v2vlc
Copy link

I can't seem to find Dockerfile for image jc5x/firefly-iii-base-image anywhere. It's not in the repository and Docker Hub does not list source repository for this image (unlike jc5x/firefly-iii).

Build script does not build this image:

https://github.com/firefly-iii/firefly-iii/blob/master/.deploy/docker/build-amd64.sh

Is this image built in some other way? If so, I believe it would be great for the project to provide some transparency into what this image contains. Otherwise it's just one big (173.37 MB) black box blob.

Dockerfile for arm64 does give some insight into how this base image might be built, but it's just a speculation at this point.

https://github.com/firefly-iii/firefly-iii/blob/master/Dockerfile.arm64

@JC5
Copy link
Member

JC5 commented Sep 24, 2019

@JC5 JC5 added the question label Sep 24, 2019
@stale
Copy link

stale bot commented Oct 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No replies or comments. Will be auto-closed in 14 days. label Oct 1, 2019
@michael-v2vlc
Copy link
Author

Apologies, I have not noticed this.

Could it be possible to at least update page on Docker Hub to include link to this repository (just like the main image jc5x/firefly-iii). Thanks a lot?

@JC5
Copy link
Member

JC5 commented Oct 9, 2019

Thanks. I've done so. The Dockerfiles will include a comment linking to the GitHub repository as well.

JC5 added a commit that referenced this issue Oct 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No replies or comments. Will be auto-closed in 14 days.
Projects
None yet
Development

No branches or pull requests

2 participants