Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation start date is allowed to be after end date #2956

Closed
GeorgeHahn opened this issue Jan 5, 2020 · 2 comments
Closed

Reconciliation start date is allowed to be after end date #2956

GeorgeHahn opened this issue Jan 5, 2020 · 2 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@GeorgeHahn
Copy link
Contributor

Bug description
I am running Firefly III version 4.8.2.

I noticed that the reconciliation interface allows a start date that takes place after the end date. The transactions shown are still between the two dates, but this seems undesirable. I did not check the output of the reconciliation calculation in this scenario.

JC5 added a commit that referenced this issue Jan 5, 2020
@JC5
Copy link
Member

JC5 commented Jan 5, 2020

Thanks for letting me know. Yes, this is possible. I've added some code to make sure that the dates are processed in the correct order. If you switch them around, by accident or on purpose, Firefly III will put them in the right order again.

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Jan 5, 2020
@GeorgeHahn
Copy link
Contributor Author

Good to know, thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants