Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent fail of split transaction from different source accounts #3265

Closed
1 task done
Loosper opened this issue Apr 15, 2020 · 7 comments
Closed
1 task done

Silent fail of split transaction from different source accounts #3265

Loosper opened this issue Apr 15, 2020 · 7 comments
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).

Comments

@Loosper
Copy link

Loosper commented Apr 15, 2020

Bug description
I am running Firefly III version 5.2.1, and my problem is:

When creating a transaction with 2 splits I can select different source accounts. However after saving it, it silently converts both of them to the first one.

My understanding from other issues is that this should not be possible. However I think it should at least be explicit (ex. grey out the second source or something along those lines).

Steps to reproduce

  1. Create a new transaction and add a split
  2. Select source account for first split
  3. Select a different source account for second split
  4. Enter amounts and budgets
  5. Submit

Bonus points

@JC5
Copy link
Member

JC5 commented Apr 15, 2020

It depends a bit on whether or not you're actively selecting the accounts. When Firefly III can predict what you're doing, this works:

Screenshot 2020-04-15 at 16 03 49

However, this isn't always the case. I'll write it up as an enhancement, and see if Firefly III can't warn you about this stuff.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Apr 15, 2020
@Loosper
Copy link
Author

Loosper commented Apr 16, 2020

Ah, I see what you mean. But then it still doesn't update if the destination is left empty:

image

Would this be a case of 'using it wrong'? In my use case I do not care where the money went, as long as it checks out as 'spent'.

@JC5
Copy link
Member

JC5 commented Apr 17, 2020

No it's not about using it wrong. What you're doing is fine.

The form is very flexible. You can enter whatever you want and Firefly III will try to handle it. There's a few limitations but nothing really solid.

In many cases, Firefly III isn't able to predict what you're trying to do (it could go both ways) so you're getting the freedom to do it either way. If it turns out (after you press submit) you hit some kind of limitation, Firefly III should warn you. That's something I want to add.

There are some users who don't use destination/source accounts to indicate where the money came from or went to, just that it did. That's OK, it works fine either way.

@Loosper
Copy link
Author

Loosper commented Apr 19, 2020

I've been trying to wrap my head around how it works, but it seems really incosistent, as an example:
image

Visually it is locked into two accounts, but again, it is submitted as the same. The warning would be nice as a feature, but I find this silent conversin to be a serious bug.

Anyway, thank you for doing this, hopefully it's fixable!

@Zsub
Copy link
Contributor

Zsub commented Jun 18, 2020

I run into a similar issue, where I try to split a transaction (deposit, or that's how I see it) coming from a single 'expense' account to two different liabilities.

Concrete: I try to split the 'betalingskorting' I get as a deposit coming from DUO across both parts of my study loan. The split works, just both splits are deposited into one part of my study loan. My workaround now is to create two transactions, but I was wondering if this was by design.

Edit: I just noticed I now have DUO both as an expense and revenue account, that makes sense as well of course.

@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Aug 7, 2020
@JC5
Copy link
Member

JC5 commented Aug 7, 2020

I've added a warning to the form.

JC5 added a commit that referenced this issue Aug 7, 2020
@JC5 JC5 closed this as completed Aug 14, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

3 participants