Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth support for public clients #3651

Closed
forcaeluz opened this issue Aug 4, 2020 · 2 comments
Closed

OAuth support for public clients #3651

forcaeluz opened this issue Aug 4, 2020 · 2 comments
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).

Comments

@forcaeluz
Copy link

Description
I've been working on a single page app that uses the API. Now I want to use oauth2 flow for single page apps, and from what I understand, the recommendation is to register a public client (one without a secret). Laravel passport seems to have support for it, but in my Firefly-III installation, the secret is mandatory, so I can't create a public client.

Solution
Allow clients without secrets (Ideally force them to use PKCE).

What are alternatives?
I could keep using a personal access token, or search for other alternatives such as having part of my application running on a server.

Additional context

Bonus points

Recommendations for OAuth2 for browser based apps: https://tools.ietf.org/html/draft-ietf-oauth-browser-based-apps-06
Laravel passport documentation: https://laravel.com/docs/7.x/passport#creating-a-auth-pkce-grant-client (I can't find if PKCE is mandatory for public clients)

@JC5
Copy link
Member

JC5 commented Aug 5, 2020

Good suggestion. This will take some changes on Firefly III's side, support for this has been added to Passport only after I started using it. I'll see what I can do.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Aug 5, 2020
JC5 added a commit that referenced this issue Aug 5, 2020
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Aug 12, 2020
@JC5 JC5 closed this as completed Aug 14, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants