Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results page size not impacted by Layout Preferences nor by .env variable #3673

Closed
psychowood opened this issue Aug 8, 2020 · 3 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@psychowood
Copy link
Contributor

psychowood commented Aug 8, 2020

Hi,
I suppose this is by design because the .env file has the specific variable SEARCH_RESULT_LIMIT), but it is probably not clear when looking at the preferences page:

image

Moreover, even changing the line in .env did not change the search results page size, tho:

image

Always 50, both increasing and decreasing SEARCH_RESULT_LIMIT

image

Docker shows the variable as correctly initialized (orrectly 10, that was another last try):

image

I'm not sure which one should be the correct behaviour...

EDIT: Restarting in debug mode did not help showing the variables in the console. The only reference I found in logs is this one:

[2020-08-08 16:12:44] local.DEBUG: Start of searchTransactions()
[2020-08-08 16:12:44] local.DEBUG: GroupCollector::startQuery
[2020-08-08 16:12:44] local.DEBUG: GroupCollector: The limit is now 50
[2020-08-08 16:12:44] local.DEBUG: GroupCollector: page is now 1
[2020-08-08 16:12:45] local.DEBUG: Will NOT set previous URL to http://dockervm:8081/search/search?page=1
[2020-08-08 16:12:49] local.DEBUG: Trying to set en_US.utf8
[2020-08-08 16:12:49] local.DEBUG: Trying to set en_US.UTF-8

@psychowood psychowood changed the title Search results page size not impacted by Layout Preferenced Search results page size not impacted by Layout Preferences Aug 8, 2020
@psychowood psychowood changed the title Search results page size not impacted by Layout Preferences Search results page size not impacted by Layout Preferences nor by .env variable Aug 8, 2020
@JC5
Copy link
Member

JC5 commented Aug 8, 2020

Nice find, the search limit isn't used as it should. Will be fixed in the next release 👍

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Aug 8, 2020
JC5 added a commit that referenced this issue Aug 8, 2020
JC5 added a commit that referenced this issue Aug 8, 2020
JC5 added a commit that referenced this issue Aug 8, 2020
@JC5
Copy link
Member

JC5 commented Aug 8, 2020

And as an FYI. The search used to be limited because it was insanely resource intensive. This is a lot less of a problem these days, so it's more of an historical thing. I've removed this variable from the preferences. So the number from your preferences will also apply to the search.

@JC5 JC5 closed this as completed Aug 14, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants