Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update transactions's currency #3675

Closed
weimdall opened this issue Aug 8, 2020 · 2 comments
Closed

Cannot update transactions's currency #3675

weimdall opened this issue Aug 8, 2020 · 2 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@weimdall
Copy link
Contributor

weimdall commented Aug 8, 2020

Bug description
I am running Firefly III version 5.3.3, and my problem is:

New updated transactions on my account are in the wrong currency when switching source account that use a different currency.
Firefly throw an error :

...
[2020-08-08 14:07:03] local.ERROR: Foreign currency is equal to normal currency (CAD)  
[2020-08-08 14:07:35] local.ERROR: Foreign currency is equal to normal currency (CAD)  
...

In the following screenshot, the first transaction has been directly created in Euro.
The second transaction has been updated and moved from an asset account in CAD.
2020-08-08-143849_5760x1757_scrot

Steps to reproduce

  1. Create an asset account in Dollar
  2. Create a second asset account in Euro
  3. Create a transaction in Dollar on the first asset account
  4. Update this transaction :
  • Switch the source asset account to the Euro one -> JS will update the currency label
  • Save
  1. The currency has not been properly edited

Extra info
Debug information generated at 2020-08-08 14:31:21 America/Montreal for Firefly III version 5.3.3.

Scope Version
Firefly III 5.3.3
Firefly III API 1.3.0
PHP 7.4.8
Host Linux
System info Value
Using docker? true
Layout
App environment local
App debug mode false
App cache driver file
App logging notice, stack
Display errors Off
Error reporting ALL errors
Interface apache2handler
Default language en_US
Default locale equal
BCscale 12
DB drivers mysql, pgsql, sqlite
Current driver pgsql
Login provider eloquent
Trusted proxies (.env) **
User info Value
Session start 2020-07-01 00:00:00
Session end 2020-09-30 00:00:00
Session first 2018-08-16 00:00:00
User ID 1
User language en_US
User locale en_US
Attempt at "en_US.utf8" 'en_US.utf8'
Attempt at "en_US.UTF-8" 'en_US.UTF-8'
User agent Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Bonus points
I was able to replicate it on the demo site https://demo.firefly-iii.org/

@weimdall weimdall changed the title Cannot update transctions's currency Cannot update transactions's currency Aug 8, 2020
@JC5
Copy link
Member

JC5 commented Aug 9, 2020

Indeed, that's a bug. Thanks!

@JC5 JC5 added the bug Verified and replicated bugs and issues. label Aug 9, 2020
JC5 added a commit that referenced this issue Aug 9, 2020
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Aug 9, 2020
@JC5 JC5 closed this as completed Aug 14, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants