Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source: (and destination:) search filters both source and destination field indistinctly #3678

Closed
psychowood opened this issue Aug 9, 2020 · 3 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@psychowood
Copy link
Contributor

psychowood commented Aug 9, 2020

Firefly III version 5.3.3 here.

I have an account named "Paypal", searching for either "source:paypal" or "destination:paypal" or both of them together leads to the same results:

image

Same behaviour on the demo site.

EDIT: I'm not sure if it is the correct point, but Search.php does not seems to differentiate between source and destination modifier.

Btw: since it is not possible to search for an account using its full name (in case of special chars/spaces), would it be possibile to make it accept the numerical account id?

@JC5
Copy link
Member

JC5 commented Aug 9, 2020

Yes, that's a bug. Nicely spotted. Clearly lazy programming on my side 😅 . Will be fixed in the next release.

@JC5
Copy link
Member

JC5 commented Aug 9, 2020

Oh and re: your last point: I'm working on a more advanced version of the query parser, which means that the following should work: source:"some account".

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Aug 9, 2020
JC5 added a commit that referenced this issue Aug 9, 2020
@JC5 JC5 closed this as completed Aug 14, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants