Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Login E-Mails #3712

Closed
niklas2810 opened this issue Aug 20, 2020 · 5 comments
Closed

Send Login E-Mails #3712

niklas2810 opened this issue Aug 20, 2020 · 5 comments
Labels
feature Requests for new stuff. fixed Bugs that are fixed (in a coming release).

Comments

@niklas2810
Copy link

Description

It would be super cool if Firefly III would notify me whenever someone logs into my Firefly instance!

Solution

Send an email to the user's address whenever someone logs in to the user's account.

IMO, this should be an optional feature (as some users might be annoyed by such notifications), therefore an entry on the configuration page would be nice.

What are alternatives?

A breadcrumb inside of Firefly III for other sessions, but I guess that an email would be more suitable as you have to be active at the time.

Bonus points

The message text could look like this, it's inspired by already existing message texts:

Hi there,

Somebody (hopefully you) just logged into your Firefly III instance at {URL}. 

(Optional: User Agent/IP address)

If this wasn't you, please change your password and invalidate sessions immediately via {URL}/profile/logout-others.

Beep boop,

The Firefly III Mail Robot
@niklas2810 niklas2810 changed the title Send Login E-Mails [Feature] Send Login E-Mails Aug 20, 2020
@JC5
Copy link
Member

JC5 commented Aug 20, 2020

I was thinking something similar recently. I like the idea. I also thought to send messages for new IP's only. What do you think?

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Aug 20, 2020
@niklas2810
Copy link
Author

niklas2810 commented Aug 20, 2020

Sounds great! Such a feature could prevent users from getting annoyed by these notifications. I think would make sense to mark these IPs with an expiration date (e.g. 6 months) then, so these logged addresses won't be valid forever (even though it is not very likely that an intruder will have the same IP address, it's rather a measure to remind to user that they will receive notifications for new logins). Edit: This feature should be explicitly mentioned in the email text then to tell the user what's going on 😄

I'm not very familiar with Firefly's internal structure, but if adding an environment variable check is not that complicated, you could also provide a configuration option in the .env file to let users choose whether they want the "trusted" IP feature to be active (which could be the default value) or alternatively, want to receive an email for every new login.

@JC5 JC5 added feature Requests for new stuff. and removed enhancement Requests for enhancements of existing stuff. labels Aug 20, 2020
@JC5 JC5 changed the title [Feature] Send Login E-Mails Send Login E-Mails Aug 20, 2020
JC5 added a commit that referenced this issue Aug 28, 2020
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Aug 28, 2020
@JC5
Copy link
Member

JC5 commented Aug 28, 2020

email

@niklas2810
Copy link
Author

This looks great, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Requests for new stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants