Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for search filter is missing #3842

Closed
niklas2810 opened this issue Sep 23, 2020 · 8 comments
Closed

Translation for search filter is missing #3842

niklas2810 opened this issue Sep 23, 2020 · 8 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@niklas2810
Copy link

Bug description
I am running Firefly III version 5.4.2 (demo site) and my problem is:

https://demo.firefly-iii.org/search?search=destination_is_cash%3Atrue

(translation missing)

Steps to reproduce

Visit link

Extra info

image

Bonus points

  • I searched and nobody reported this bug before
  • I have added a screenshot.
  • I was able to replicate it on the demo site https://demo.firefly-iii.org/
@JC5
Copy link
Member

JC5 commented Sep 23, 2020

Nicely spotted. Also fixed "source_is_cash".

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Sep 23, 2020
JC5 added a commit that referenced this issue Sep 23, 2020
@niklas2810
Copy link
Author

In rule triggers you always write (cash) account, wouldn't it be more consistent to write it on the search page as well instead of only cash? 😅

@niklas2810
Copy link
Author

niklas2810 commented Sep 23, 2020

source_is_cash = Source account is (cash) account
destination_is_cash = Destination account is (cash) account

@JC5
Copy link
Member

JC5 commented Sep 23, 2020

Fair point, that would be more clear 👍

JC5 added a commit that referenced this issue Sep 23, 2020
@niklas2810
Copy link
Author

Thanks! I've updated the translations for the German language (for 5.4.0+, these have been missing). When you build the new docker image/publish the next release, would it be possible for you to pull the update from crowdin before this? 😄 It's quite confusing to see the mixed-up language on my production instance 😅

@JC5
Copy link
Member

JC5 commented Sep 23, 2020

Can do! 👍

As your neighbor (NL) I feel I can make the joke about German pünktlichkeit? 😉 😅

@niklas2810
Copy link
Author

Ugh, I guess you've got a point there 😅 😂 Thanks! 😃

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants