Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything on the V2 dashboard is off by 1 day #4571

Closed
2 of 4 tasks
death2cupbots opened this issue Mar 31, 2021 · 5 comments
Closed
2 of 4 tasks

Everything on the V2 dashboard is off by 1 day #4571

death2cupbots opened this issue Mar 31, 2021 · 5 comments
Labels
bug Verified and replicated bugs and issues.

Comments

@death2cupbots
Copy link

Bug description
I am running Firefly III version 5.5.1 (layout v2) and my problem is:

Everything on the V2 layout is listed one day earlier than it should be.

Here's my date range:
image

I'll start small and super obvious:
Here's a bill:
image
You can see that the next expected match is March 15, 2021.
Here's the same exact bill on the v2 dashboard:
image
You can see here that the next expected match is March 14, 2021.

Here's a test transaction in process:
image

Here it is after I made it (also a day earlier for some reason?):
image

And here it is a day earlier that that on the dashboard:
image

So apparently if you make your transaction for any day earlier than today, it sets it back a day earlier than that. Do you want a different bug report for that?

The asset account graph starts February 28 instead of March 1 (that might be intentional?)
image

The range on the custom timed budgets is also off by a day on both ends:
image

Steps to reproduce

  1. Be on the V2 layout
  2. Have bills or budgets
  3. Look at the dates

Extra info

Debug information generated at 2021-03-31 14:53:21 America/New_York for Firefly III version 5.5.1.

Scope Version
Firefly III 5.5.1
Firefly III API 1.5.0
PHP 8.0.3
Host Linux
System info Value
Installation ID 33fe0fbe-cfee-496b-81fa-a926233790d2
Using docker? false
Telemetry false
Layout v2
App environment local
App debug mode false
App cache driver file
App logging notice, stack
Display errors Off
Error reporting ALL errors
Interface fpm-fcgi
Default language en_US
Default locale equal
BCscale 12
DB drivers mysql
Current driver mysql
DB version 16 (exp. 16)
Login provider eloquent
Trusted proxies (.env) **
User info Value
Session start 2021-03-01 00:00:00
Session end 2021-03-31 23:59:59
Session first 2019-06-17 00:00:00
User ID 1
User language en_US
User locale en_US
Attempt at "en_US.utf8" 'en_US.utf8'
Attempt at "en_US.UTF-8" 'en_US.UTF-8'
User agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.105 Safari/537.36

Bonus points

  • I searched and nobody reported this bug before (I thought I saw a report like this but I couldn't find it.
  • I have added a stack trace from my log files
  • - I have added a screenshot.
  • I was able to replicate it on the demo site https://demo.firefly-iii.org/ (Demo site is v1)
@JC5
Copy link
Member

JC5 commented Apr 1, 2021

I know it happens when you're using Firefox, because the dates are often formatted as UTC in Firefox. I'll check it out!

@JC5
Copy link
Member

JC5 commented Apr 1, 2021

Oh and that may also explain why the next/previous is off. It takes the date, turns it into a Javascript date object, which is UTC, which is then a day earlier becayse NY is at -6 or something.

@JC5 JC5 added the bug Verified and replicated bugs and issues. label Apr 1, 2021
@JC5
Copy link
Member

JC5 commented Apr 1, 2021

Yep that's it. Every date jumps back X hours. I'll see what I can do.

@JC5
Copy link
Member

JC5 commented Apr 1, 2021

This will be fixed in 5.5.2 👍

JC5 added a commit that referenced this issue Apr 1, 2021
JC5 added a commit that referenced this issue Apr 1, 2021
JC5 added a commit that referenced this issue Apr 1, 2021
@JC5 JC5 closed this as completed in 93dc5fa Apr 3, 2021
@death2cupbots
Copy link
Author

Ok the dashboard looks good now, but I'm still having my transactions jump back a day. This only happens if you type anything in the date box. If I leave it set to today, it posts with the correct date. If I change the date box at all even if you just type over it with the current date, it posts back a day. Changing the time box has no effect on the date. The time of the transaction does not matter. This is not happening in V1, and transactions made in V1 stay the correct date when shifting to V2.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues.
Projects
None yet
Development

No branches or pull requests

2 participants