Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Time on transactions in V2 is strange #4578

Closed
2 of 4 tasks
death2cupbots opened this issue Apr 1, 2021 · 9 comments
Closed
2 of 4 tasks

Editing Time on transactions in V2 is strange #4578

death2cupbots opened this issue Apr 1, 2021 · 9 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@death2cupbots
Copy link

death2cupbots commented Apr 1, 2021

Bug description
I am running Firefly III version 5.5.1 (v2), and my problem is:

I'm sure it's still a work in progress and I'm not actually supposed to edit the time yet, but when you do go to edit the time, the box completely breaks down:
Fireflyiiitime
No matter what I try to do, I cannot put in a new time in that box.

I've tried entering it out by hand and scrolling through the numbers with the arrow keys. If I try to put seconds in, nothing happens. If I try to do AM/PM, the box clears out.

EDIT: It seems to work if you lead with any number other than 0 in the seconds slot:
Fireflyiiitime2

There is no way to restore the time box aside from restarting the whole transaction. So if we're not actually supposed to be able to edit the time box yet, could you make it so we cannot edit the box?

EDIT: It does work when you click on the clock and go through that menu to set the time:
Fireflyiiitime3
You cannot get the seconds back once you set them to 0 though.

Also, this date:
image
which is normally a valid input is not ISO 8601.

Steps to reproduce

  1. Be in Layout V2
  2. Create a transaction
  3. Try to change the time
  4. Fail at completing the box

Extra info

Debug information generated at 2021-04-01 15:58:25 America/New_York for Firefly III version 5.5.1.

Scope Version
Firefly III 5.5.1
Firefly III API 1.5.0
PHP 8.0.3
Host Linux
System info Value
Installation ID 33fe0fbe-cfee-496b-81fa-a926233790d2
Using docker? false
Telemetry false
Layout v2
App environment local
App debug mode false
App cache driver file
App logging notice, stack
Display errors Off
Error reporting ALL errors
Interface fpm-fcgi
Default language en_US
Default locale equal
BCscale 12
DB drivers mysql
Current driver mysql
DB version 16 (exp. 16)
Login provider eloquent
Trusted proxies (.env) **
User info Value
Session start 2021-04-01 00:00:00
Session end 2021-04-30 23:59:59
Session first 2019-06-17 00:00:00
User ID 1
User language en_US
User locale en_US
Attempt at "en_US.utf8" 'en_US.utf8'
Attempt at "en_US.UTF-8" 'en_US.UTF-8'
User agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.105 Safari/537.36

Bonus points

  • I searched and nobody reported this bug before
  • I have added a stack trace from my log files
  • I have added a screenshot. (Please appreciate that I downloaded a gif making program just for this)
  • I was able to replicate it on the demo site https://demo.firefly-iii.org/
@death2cupbots death2cupbots changed the title Cannot Edit Time in V2 Editing Time on transactions in V2 is strange Apr 1, 2021
@JC5
Copy link
Member

JC5 commented Apr 2, 2021

Weird. It works fine for me. The dropdowns, the buttons, it all works. Chrome on a Mac. I see some issues in the edit screen but that's not a part of 5.5.1 yet.

I'll see what I can find!

@JC5 JC5 added the bug Verified and replicated bugs and issues. label Apr 2, 2021
@JC5
Copy link
Member

JC5 commented Apr 2, 2021

Made some changes, works for me ™️ in Chrome.

@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Apr 2, 2021
@JC5
Copy link
Member

JC5 commented Apr 3, 2021

5.5.2 is released.

@JC5 JC5 closed this as completed Apr 3, 2021
@JC5 JC5 reopened this Apr 3, 2021
@death2cupbots
Copy link
Author

Ok time editing seems to be working on new transactions. If I go to edit the time on an existing transaction, the minutes only let you add a second number if you double tap the first number. So if you want "5:47," you would have to type 5 : 4 4 7
fireflyiiitime6

@JC5
Copy link
Member

JC5 commented Apr 3, 2021

Hah, that's weird. It's also weird that Chrome doesn't offer to change the seconds. I can't replicate this in Chrome btw. Which browser are you using exactly?

@death2cupbots
Copy link
Author

death2cupbots commented Apr 3, 2021

I'm using Brave 1.22.71 on Manjaro Linux. I'll bop over to Windows at some point today to see if I can replicate it in Chrome.

EDIT: I am running into the same exact behavior in Windows on Chrome. I have to double tap on both the hours and the minutes. It does not happen to me on Firefox though. Firefox lets me keep editing the seconds too.

It needs to be a transaction that doesn't have seconds on it. If I make a new transaction and don't lose the seconds, I have no problem editing the time in chrome.

@JC5 JC5 removed the fixed Bugs that are fixed (in a coming release). label Apr 3, 2021
@JC5
Copy link
Member

JC5 commented Apr 3, 2021

Stranger and stranger. Let me work on it the next few days. I was hoping for a quick fix but alas.

I also realised Safari doesn't even support time so I have more work to do :D

@JC5
Copy link
Member

JC5 commented Apr 9, 2021

Removed lots of code, but couldn't fully test this. Let me know!

@death2cupbots
Copy link
Author

Hey this seems to be working totally fine on 5.5.7. Thanks! Also, glad to see you dropped the seconds field on the time!

@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Apr 12, 2021
@JC5 JC5 closed this as completed Apr 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants