New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing Time on transactions in V2 is strange #4578
Comments
Weird. It works fine for me. The dropdowns, the buttons, it all works. Chrome on a Mac. I see some issues in the edit screen but that's not a part of 5.5.1 yet. I'll see what I can find! |
Made some changes, works for me ™️ in Chrome. |
5.5.2 is released. |
Hah, that's weird. It's also weird that Chrome doesn't offer to change the seconds. I can't replicate this in Chrome btw. Which browser are you using exactly? |
I'm using Brave 1.22.71 on Manjaro Linux. I'll bop over to Windows at some point today to see if I can replicate it in Chrome. EDIT: I am running into the same exact behavior in Windows on Chrome. I have to double tap on both the hours and the minutes. It does not happen to me on Firefox though. Firefox lets me keep editing the seconds too. It needs to be a transaction that doesn't have seconds on it. If I make a new transaction and don't lose the seconds, I have no problem editing the time in chrome. |
Stranger and stranger. Let me work on it the next few days. I was hoping for a quick fix but alas. I also realised Safari doesn't even support time so I have more work to do :D |
Removed lots of code, but couldn't fully test this. Let me know! |
Hey this seems to be working totally fine on 5.5.7. Thanks! Also, glad to see you dropped the seconds field on the time! |
Bug description
I am running Firefly III version 5.5.1 (v2), and my problem is:
I'm sure it's still a work in progress and I'm not actually supposed to edit the time yet, but when you do go to edit the time, the box completely breaks down:
No matter what I try to do, I cannot put in a new time in that box.
I've tried entering it out by hand and scrolling through the numbers with the arrow keys. If I try to put seconds in, nothing happens. If I try to do AM/PM, the box clears out.
EDIT: It seems to work if you lead with any number other than 0 in the seconds slot:
There is no way to restore the time box aside from restarting the whole transaction. So if we're not actually supposed to be able to edit the time box yet, could you make it so we cannot edit the box?
EDIT: It does work when you click on the clock and go through that menu to set the time:
You cannot get the seconds back once you set them to 0 though.
Also, this date:
which is normally a valid input is not ISO 8601.
Steps to reproduce
Extra info
Debug information generated at 2021-04-01 15:58:25 America/New_York for Firefly III version 5.5.1.
Bonus points
I was able to replicate it on the demo site https://demo.firefly-iii.org/The text was updated successfully, but these errors were encountered: