Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rule triggers/actions broken #5144

Closed
3 tasks done
Alaksin opened this issue Oct 1, 2021 · 1 comment
Closed
3 tasks done

Remove rule triggers/actions broken #5144

Alaksin opened this issue Oct 1, 2021 · 1 comment
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@Alaksin
Copy link

Alaksin commented Oct 1, 2021

Support guidelines

I've found a bug and checked that ...

  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

When editing a rule, if I try to remove a trigger or action, only the delete icon gets removed, the rest of the row stays. When pressing save the trigger/action may or may not be removed, it's a lucky roll. Most of the times only one trigger/action is removed even if I remove several.

Expected behaviour

The whole row should be removed and when saving the deleted triggers/actions should be removed from the rule

Debug information

Debug information generated at 2021-10-01 09:35:48 Asia/Kuala_Lumpur for Firefly III version 5.6.1.

Scope Version
Firefly III 5.6.1
Firefly III API 1.5.4
PHP 8.0.10
Host Linux
System info Value
Installation ID 6ec83b7f-8f96-4c74-b42c-97b6c8e09ab6
Using docker? true
Telemetry false
Layout
System TZ Asia/Kuala_Lumpur
Browser TZ Asia/Kuala_Lumpur
App environment local
App debug mode false
App cache driver file
App logging info, stack
Display errors Off
Error reporting ALL errors
Interface apache2handler
Default language en_US
Default locale equal
BCscale 24
DB drivers mysql, pgsql, sqlite
Current driver mysql
DB version 18 (exp. 18)
Login provider eloquent
Trusted proxies (.env)
User info Value
Session start 2021-10-01 00:00:00
Session end 2021-10-31 23:59:59
Session first 2017-08-25 00:00:00
User ID 1
User language en_US
User locale en_US
Attempt at "en_US.utf8" 'en_US.utf8'
Attempt at "en_US.UTF-8" 'en_US.UTF-8'
User agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce

  1. Edit a rule, preferable with several triggers/actions
  2. Remove some triggers/actions in random order
  3. Save

Additional info

No response

@JC5
Copy link
Member

JC5 commented Oct 1, 2021

I see what you mean. For the time being, click on the red part of the button.

@JC5 JC5 added the bug Verified and replicated bugs and issues. label Oct 1, 2021
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Oct 1, 2021
@JC5 JC5 closed this as completed in d447f5f Oct 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants