Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New expense account created if original same-named expense account is set to 'not active' #764

Closed
tannie opened this issue Aug 14, 2017 · 4 comments
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@tannie
Copy link

tannie commented Aug 14, 2017

When I have expense account set to 'not active' and then create a withdrawal and fill in the name of the expense account (or, I get a suggestion after typing the first few letters and select it), I end up with two expense accounts with the same name. One active, one inactive.
I would expect the inactive account to become active again, and the withdrawal going into that account. I have tested this on the demo site and the same thing happens there, however, I did set the expense account to inactive manually. On my server I've had this experience with automatic inactive accounts.
Related to this: what is the idea behind setting accounts to inactive automatically? For speed?

Would it make more sense to activate the original account when I create a new transaction with that expense account name?

@JC5
Copy link
Member

JC5 commented Aug 14, 2017

No accounts should be made inactive automatically. There's no such process. There was a bug that made editing them inactive.

I'll look into these other things this week!

JC5 added a commit that referenced this issue Aug 15, 2017
@JC5
Copy link
Member

JC5 commented Aug 15, 2017

In the new release, the auto-suggest box will no longer suggest inactive accounts. If you type them in manually, they will be reactivated.

I wonder how your accounts came to be inactive. Were these accounts you manually edited?

@JC5 JC5 self-assigned this Aug 15, 2017
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). waiting-for-user labels Aug 15, 2017
@tannie
Copy link
Author

tannie commented Aug 16, 2017

I didn't edit accounts directly as far as I remember, but I did merge a couple and moved transactions from one expense account to another. I had imported a bunch of transactions (thousands... dating back to 2006 😉 ) and needed to do some cleanup, I didn't check after every change I made...

It hasn't happened since the latest update and I'm still doing cleanup so I think that whatever caused it got fixed, but I'll keep an eye on it, just in case.

@JC5
Copy link
Member

JC5 commented Aug 16, 2017

Please do, and keep me posted. 👍

If you find anything else, don't hesitate to report it!

@JC5 JC5 closed this as completed Aug 23, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants