Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: clicking on the search-icon renders error page #848

Closed
AndreiGavriliu opened this issue Sep 15, 2017 · 2 comments
Closed

Search: clicking on the search-icon renders error page #848

AndreiGavriliu opened this issue Sep 15, 2017 · 2 comments
Assignees
@JC5
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@AndreiGavriliu
Copy link

How to reproduce

  1. do not type anything in the search form (left nav-bar)
  2. click on the magnifying glass / search icon

Error:

Whoops! An error occurred.
Unfortunately, this error was not recoverable. Firefly III broke. The error is:

Type error: Argument 1 passed to FireflyIII\Support\Search\Search::parseQuery() must be of the type string, null given, called in /var/www/firefly-iii/app/Http/Controllers/SearchController.php on line 57

More information about this error may be available in the log files. Search for the error above and a stack trace will appear. This stack trace may help you track down what's going wrong.

If you cannot find the cause of this error or when you need some help, please open a ticket on Github.
@JC5
Copy link
Member

JC5 commented Sep 16, 2017

Nice. Found and fixed!

@JC5 JC5 self-assigned this Sep 16, 2017
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Sep 16, 2017
JC5 added a commit that referenced this issue Sep 16, 2017
@JC5
Fixes #848
bbab89d
@JC5
Copy link
Member

JC5 commented Sep 21, 2017

Closed to clean the list of issues.

@JC5 JC5 closed this as completed Sep 21, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JC5 JC5

Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreiGavriliu @JC5