CSV importer uses "contains" to detect duplicates in External ID

[RobinWeitzel]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem
• ... it's definitely a Firefly III issue, not me

Description

When doing a CSV import using "External ID" to detect duplicates Firefly seems to check "contains" instead of "equals" causing transactions being mistakenly labeled as duplicate.

Debug information

Debug information generated at 2024-02-24 11:14:36 for Firefly III version v6.1.9.

System information
Item	Value
Firefly III	6.1.9 / v2.0.12 / 22 (exp. 22)
PHP version	8.3.2 / apache2handler / Linux
BCscale	12
Error reporting	Display: Off, reporting: ALL errors
Max upload	67108864 (64 MB)
Database drivers	mysql, *pgsql*, sqlite,
Docker build	#957, base #79

Firefly III information
Item	Value
Timezone	America/Los_Angeles + Europe/Vienna
App environment	local, debug: false
Layout	v1
Logging	info, stack / (empty)
Cache driver	file
Default language and locale	en_US + equal
Trusted proxies	**
Login provider & user guard	eloquent / remote_user_guard
Login headers	Remote-Email +
Stateful domains
Last cron job	never (never)
Mailer	log

User-specific information
Item	Value
User	#1 of 1
User flags
Session start	2024-02-01 00:00:00
Session end	2024-02-29 23:59:59
View range	1M
User language	en_US
User locale	en_US
Locale(s) supported	en_US.utf8: ✅ en_US.UTF-8: ✅
User agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36

Expected behaviour

Both transactions are imported

Steps to reproduce

Create a CSV file for import, containing at least the following fields:
xxx,ID,xxx
xxx,5682,xxx
xxx,682,xxx
Run a csv import using the Firefly importer.
Use the ID column to identify duplicates.

Additional info

Error shown in importer

Transaction that the link leads to:

[JC5]

Nice, I'm pretty sure you're right 😅. I'll pick it up!

[JC5]

Found and fixed :)

[RobinWeitzel]

Thanks, appreciate your work :)

[github-actions]

Hi there! This is an automatic reply. Share and enjoy

This issue is now 🔒 closed. Please be aware that closed issues are not monitored by the developer of Firefly III.

• If the original bug is not actually fixed, please open a new issue. Refer to this issue for clarity.
• Follow-up questions must be posted in a new discussion
• Further replies to this issue may get no response.

If there is more to discuss, please open a new issue or discussion.

Thank you for your contributions.