Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting transactions don't understand new format of notes #942

Closed
pkoziol opened this issue Oct 19, 2017 · 5 comments
Closed

Splitting transactions don't understand new format of notes #942

pkoziol opened this issue Oct 19, 2017 · 5 comments
Assignees
@JC5
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@pkoziol
Copy link
Contributor

pkoziol commented Oct 19, 2017

When splitting transaction notes textarea contains JSON array with notes objects or just empty array "[]".
JC5 added a commit that referenced this issue Oct 19, 2017
@JC5
Fix #942
c53618d
@JC5
Copy link
Member

JC5 commented Oct 19, 2017

Fixed, thanks for noticing!

@JC5 JC5 self-assigned this Oct 19, 2017
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Oct 19, 2017
@AndreiGavriliu
Copy link

I tried it today and got the following error:

Type error: Argument 2 passed to FireflyIII\Repositories\Journal\JournalRepository::updateNote() must be of the type string, null given, called in /var/www/firefly-iii/app/Repositories/Journal/JournalRepository.php on line 338

@JC5
Copy link
Member

JC5 commented Oct 20, 2017

I’ll take a look at it 👍

JC5 added a commit that referenced this issue Oct 20, 2017
@JC5
Fix #942
4d6c679
JC5 added a commit that referenced this issue Oct 20, 2017
@JC5
Fix view of #942
30bfdda
@AndreiGavriliu
Copy link

I was able to split my transaction. Thanks! 👍

@pkoziol
Copy link
Contributor Author

pkoziol commented Oct 20, 2017

Verified on demo. "[]" no longer appears.

@pkoziol pkoziol closed this as completed Oct 20, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JC5 JC5

Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndreiGavriliu @pkoziol @JC5