Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function does not find all transactions #963

Closed
AndreiGavriliu opened this issue Oct 30, 2017 · 7 comments
Closed

Search function does not find all transactions #963

AndreiGavriliu opened this issue Oct 30, 2017 · 7 comments
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@AndreiGavriliu
Copy link

I am running Firefly III version 4.6.9

Description of my issue:

I exported all the transactions to see what I can rename/organize using rules to have a better overview
I found the following transactions which were not matched by one of the rules (it was e trigger mistake on my side). I fixed the rule, the transactions were renamed/organized correctly, however the search function does not find two (or maybe more) of them:

All expenses between July 1, 2016 and July 31, 2016
2017-10-30 12_00_26-all expenses between july 1 2016 and july 31 2016 transactions firefly iii

Number of transactions found: 20
2017-10-30 11_58_31-search results for fuel search firefly iii

Other important details (log files, system info):

As you can see, the search does not return any transactions from 2016. I have tried the following:

  1. renamed a transaction from "Fuel" to "Fuels" and back to "reset" it
  2. did a artisan ca:cl
@JC5
Copy link
Member

JC5 commented Oct 30, 2017

The search has a hard-coded limit of 20.

You can use date-ranges to search in ranges of time (per year or per month). I shall make the limit something you can configure.

@AndreiGavriliu
Copy link
Author

AndreiGavriliu commented Oct 30, 2017

I tried to set the date ranges in the navbar (search ignores them), or directly in the search form fuel on:2016-07-18 but the latter one returns nothing. I am sure I am doing something wrong here, can you help? how do I have to format the search string? I also tried using the before:date and after:date options

@JC5
Copy link
Member

JC5 commented Oct 30, 2017

It seems to work for me but I’ll have to debug at a later moment. I’ll get back to you.

@AndreiGavriliu
Copy link
Author

AndreiGavriliu commented Oct 30, 2017

Just an update:

I have tried the following:

  • fuel on:2016-07-18 => returned 0 results
  • fuel on:2017-10-23 => returned 1 result (correct match)

@JC5 JC5 self-assigned this Oct 30, 2017
@JC5 JC5 added the bug Verified and replicated bugs and issues. label Oct 30, 2017
JC5 added a commit that referenced this issue Oct 30, 2017
@JC5
Copy link
Member

JC5 commented Oct 30, 2017

I've pushed a few changes that should fix this. Reason it didn't return anything is probably because it couldn't find it within 30 seconds. This has been improved making most searches doable within 30 seconds.

@AndreiGavriliu
Copy link
Author

I can confirm, it returned all the entries matching "fuel" - thanks!

@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Oct 31, 2017
@JC5
Copy link
Member

JC5 commented Nov 3, 2017

Closed, a new release is live.

@JC5 JC5 closed this as completed Nov 3, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants