Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget - Period navigator date selectors #971

Closed
AndreiGavriliu opened this issue Nov 1, 2017 · 4 comments
Closed

Budget - Period navigator date selectors #971

AndreiGavriliu opened this issue Nov 1, 2017 · 4 comments
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@AndreiGavriliu
Copy link

I am running Firefly III version 4.6.9

Description of my issue:

I wanted to see how the date selectors in the budget navigator work, what exactly they do and have the following questions:

  1. Why are there two selectors? (one on the left and one on the right side of the navigator)
  2. Why are some months in each selector missing?
  3. Why are they not identical, and if this is not a bug, why can't I select both of them to create a longer period? (the page refreshes)

Other important details (log files, system info):

Left selector:
screen shot 2017-11-01 at 14 56 10

Selected period:
November 2017

Right selector:
screen shot 2017-11-01 at 14 56 19

@JC5
Copy link
Member

JC5 commented Nov 1, 2017

The left and right selector select the previous and next period, respectively.

The reason there are months missing is because you have selected the "quarter of a year"-view in your preferences, which is reflected in your budget overview. However, the "quarter of a year" date indicator is a little broken. Contrary to the week ("week 34"), month ("september") or even day indicator ("12 sept 2017") the quarter indicator should either be a range ("jan-mar" or "jan-apr") or an indicator of the quarter (Q1, Q2, etc).

This is currently not implemented well making this list confusing: the left selector has the start of each quarter: 1 oct, 1 jul, 1 apr, 1 jan, etc. The right selector has the final date of each quarter 31 dec, 31 mar, 31 jun.

Both should display "Q2 2017" or "Q3 2018" or something similar.

@AndreiGavriliu
Copy link
Author

Now I get it. It does make sense now :)

JC5 added a commit that referenced this issue Nov 1, 2017
@JC5
Copy link
Member

JC5 commented Nov 1, 2017

I've pushed some code to clarify this 👍

@JC5 JC5 self-assigned this Nov 1, 2017
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Nov 1, 2017
@JC5
Copy link
Member

JC5 commented Nov 3, 2017

Closed, a new release is live.

@JC5 JC5 closed this as completed Nov 3, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants