Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow render times for /tags page #993

Closed
AndreiGavriliu opened this issue Nov 13, 2017 · 5 comments
Closed

Slow render times for /tags page #993

AndreiGavriliu opened this issue Nov 13, 2017 · 5 comments
Assignees
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@AndreiGavriliu
Copy link

I am running Firefly III version 4.6.10

Description of my issue:

I am aware RPi is really slow, but the /tags page is way slower than anything eles, maybe the there's place for improvements?

https://my.host.name/

Name Offset (ms) Duration (ms)
App cache 1100 0
DNS lookup 1100 0
TCP connection 1100 0
TCP request 1105 2180
TCP response 3285 94
Processing 3287 1079
onload event 4366 2

https://my.host.name/tags

Name Offset (ms) Duration (ms)
App cache 0 8
DNS lookup 8 1
TCP connection 9 4
TCP request 13 53
TCP response 66 35831
Processing 35856 1048
onload event 36904 1

Steps to reproduce

I can't currently reproduce it on the demo site since there are only 4 tags, and I have about 70+. I used this addon

@JC5
Copy link
Member

JC5 commented Nov 13, 2017

I can't be sure at the moment, but I suspect various queries are very slow, an effect which gets worse and worse when more tags are involved. I'll check it.

@JC5
Copy link
Member

JC5 commented Nov 13, 2017

Yep. Massive queries. I'll optimize the view.

@AndreiGavriliu
Copy link
Author

Good news. Thanks!

JC5 added a commit that referenced this issue Nov 13, 2017
@JC5
Copy link
Member

JC5 commented Nov 13, 2017

I've pushed a fix!

@AndreiGavriliu
Copy link
Author

It works great. Even on my crappy RPi. Great job!

@JC5 JC5 self-assigned this Nov 14, 2017
@JC5 JC5 added enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release). labels Nov 14, 2017
@JC5 JC5 added this to the 4.6.11 milestone Nov 16, 2017
@JC5 JC5 closed this as completed Nov 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants