Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currencies JSON list #994

Closed
bektasaykut opened this issue Nov 15, 2017 · 6 comments
Closed

Currencies JSON list #994

bektasaykut opened this issue Nov 15, 2017 · 6 comments
Assignees
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@bektasaykut
Copy link

I've just started to use Firefly III.

When creating currencies, wouldn't it be easy if we can choose currencies from a list?

There is a project https://github.com/xsolla/currency-format

https://raw.githubusercontent.com/xsolla/currency-format/master/currency-format.json

("JSON with information about currencies: codes (ISO 4217), the names, grapheme (symbols), fraction and formatting.")

It contains all worlds money currencies except sort of coin currencies.

I'll try to code it. But I am a newbie for Laravel and twig for now.

@JC5
Copy link
Member

JC5 commented Nov 15, 2017

That looks pretty cool!

I could use the list as a source for the import of transaction currencies but unfortunately I cannot use the list directly. I need them to be in the database.

It's also a very long list. I would suggest a sensible selection for each continent, what do you think?

@bektasaykut
Copy link
Author

I think there can be a select list on currency edit/create views. And can be filled by this JSON.

@JC5
Copy link
Member

JC5 commented Nov 15, 2017

Great! I will make sure more currencies will be available in the next release of Firefly III. Not all of them, but more :).

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Nov 16, 2017
@bektasaykut
Copy link
Author

There is two possibilities for data.

  1. Use static JSON list
  2. Export JSON list to db.
  3. Shrink the list.

My suggestion wasn't that putting all currencies tofirefly currencies page.
On the currencies page, while adding new currency to account, there will be only one search box or select list. No need to other options such as symbol, code etc. Because all needed data will be in JSON or db.

Thanks

@JC5
Copy link
Member

JC5 commented Nov 16, 2017

I get it, thanks for explaining it!

@JC5 JC5 added this to the 4.6.11 milestone Nov 16, 2017
JC5 added a commit that referenced this issue Nov 18, 2017
@JC5
Copy link
Member

JC5 commented Nov 18, 2017

Alright, I've been experimenting and I've opted to do the following. Adding currencies using the JSON as a base works but isn't user friendly, with the long list and all. I could add a search of course but I feel it would fix a problem that does not need to exist.

Very few people request new currencies (most people use the built-in ones) and adding them isn't that hard (ie. they don't need that much help).

So, I've decided to expand the list of currencies to include three from each region of the world. This is more or less an arbitrary pick from my side but I feel that this should cover most people's needs.

@JC5 JC5 closed this as completed Nov 18, 2017
@JC5 JC5 reopened this Nov 18, 2017
@JC5 JC5 self-assigned this Nov 18, 2017
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Nov 18, 2017
@JC5 JC5 closed this as completed Nov 20, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants