Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing CSP directive and value #1963

Merged
merged 2 commits into from Jan 3, 2019
Merged

Fixed missing CSP directive and value #1963

merged 2 commits into from Jan 3, 2019

Conversation

BoGnY
Copy link
Contributor

@BoGnY BoGnY commented Jan 2, 2019

Changes in this pull request:

  • Fixed CSP value that block Google Fonts and fonts loaded by (local) base64 code
  • Added CSP directive to load manifest file (site.webmanifest)

@JC5

Signed-off-by: Luca Bognolo <git@bogny.eu>
@coveralls
Copy link

coveralls commented Jan 3, 2019

Coverage Status

Coverage increased (+0.006%) to 70.117% when pulling 59cfaa2 on BoGnY:fix/csp-directive into 4646422 on firefly-iii:develop.

@JC5
Copy link
Member

JC5 commented Jan 3, 2019

Thanks for adding the manifest!

There should be no font-data coming from Google. Where did you run into it?

@BoGnY
Copy link
Contributor Author

BoGnY commented Jan 3, 2019

I'll investigate... I've read the CSP message error on Chrome console log 😅

EDIT:
This is my console log without font-src changes:

image

So adding data: fix the first error, but I can't find where is the code that load Google Fonts...
Need more investigation, I'm doing it 👍

Signed-off-by: Luca Bognolo <git@bogny.eu>
@JC5
Copy link
Member

JC5 commented Jan 3, 2019

There is no code in Firefly III that loads external fonts. I specifically programmed it to be that way. Are you running extra plugins or extensions?

@JC5 JC5 merged commit 16ba65c into firefly-iii:develop Jan 3, 2019
@JC5
Copy link
Member

JC5 commented Jan 3, 2019

I've merged this one, thanks!

@BoGnY
Copy link
Contributor Author

BoGnY commented Jan 3, 2019

@JC5 commented on #1963:

There is no code in Firefly III that loads external fonts. I specifically programmed it to be that way. Are you running extra plugins or extensions?

Yes, it's my fault.. I was writing 'EDIT 2' in my previous comment when you merged it, that extra fonts was loaded by an extension of my browser.. sorry 😄

@BoGnY BoGnY deleted the fix/csp-directive branch January 3, 2019 15:18
@BoGnY
Copy link
Contributor Author

BoGnY commented Jan 3, 2019

@JC5 this PR fixes even #1725 because allows loading of web-manifest

@JC5
Copy link
Member

JC5 commented Jan 3, 2019

Indeed!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants