Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer hard code storageClass and don't assume RWX #69

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

NerdyShawn
Copy link

Fixes issue # 8651

Changes in this pull request:

  • Remove hardcoded value of storageClass for the db chart inside the stack chart
  • Remove ReadWriteMany accessMode hardcode as well, as this will also depend on if the storageClass used supports it

@JC5
Copy link
Member

JC5 commented Mar 9, 2024

Alright check out the lint errors, and make sure it works before AND after your changes, also if you do have nfs available.

@NerdyShawn
Copy link
Author

NerdyShawn commented Mar 9, 2024

Ok so I've validated the values on a civo cluster and a local on prem raspberry pi cluster with different storageClasses. Both pvc's are now installing ok for me with their respective storageClasses.

The issue I'm running into at both sites is something about an application key missing, though I think that was a separate issue I was seeing before these changes anyway.

Updated version.
[2024-03-06 16:06:19] local.INFO: Could not create or generate installation ID. Do not continue.  
+------------------------------------------------------------------------------+
|                                                                              |
| Thank you for installing Firefly III, v5.6.14!                               |
|                                                                              |
|                                                                              |
+------------------------------------------------------------------------------+
Go!
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 10.42.13.150. Set the 'ServerName' directive globally to suppress this message
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 10.42.13.150. Set the 'ServerName' directive globally to suppress this message
[Wed Mar 06 16:06:20.325442 2024] [mpm_prefork:notice] [pid 1] AH00163: Apache/2.4.38 (Debian) configured -- resuming normal operations
[Wed Mar 06 16:06:20.325598 2024] [core:notice] [pid 1] AH00094: Command line: 'apache2 -D FOREGROUND'
[2024-03-06 16:06:24] local.INFO: Could not create or generate installation ID. Do not continue.  
[Wed Mar 06 16:06:24.411765 2024] [php:error] [pid 405] [client 10.42.13.1:41446] PHP Fatal error:  Uncaught Illuminate\\Encryption\\MissingAppKeyException: No application encryption key has been specified. in /var/www/html/vendor/laravel/framework/src/Illuminate/Encryption/EncryptionServiceProvider.php:101\nStack trace:\n#0 /var/www/html/vendor/laravel/framework/src/Illuminate/Support/helpers.php(263): Illuminate\\Encryption\\EncryptionServiceProvider->Illuminate\\Encryption\\{closure}()\n#1 /var/www/html/vendor/laravel/framework/src/Illuminate/Encryption/EncryptionServiceProvider.php(103): tap()\n#2 /var/www/html/vendor/laravel/framework/src/Illuminate/Encryption/EncryptionServiceProvider.php

I assume that's because of the password field used in the env config in the chart? I didn't find any k8s secret deployed to reference for database creds perhaps causing the app pod to never go healthy maybe? Sorry not trying to mix the two issues, but I haven't used the app yet was mainly trying to give it a spin via helm first.

# environment variables
configs:
RESTORE_URL: ""
BACKUP_URL: ""
PGPASSWORD: "YOURDBPASSWORD"
DBHOST: firefly-firefly-db
DBPORT: "5432"
DBNAME: firefly
DBUSER: firefly
TZ: Europe/Berlin

@JC5 JC5 merged commit 37083bf into firefly-iii:main Apr 1, 2024
3 checks passed
@NerdyShawn NerdyShawn deleted the stackChartStorageClassChanges branch April 1, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants