Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Scopes] Save variable expand state while stepping #3269

Closed
jasonLaster opened this issue Jul 5, 2017 · 7 comments
Closed

[Scopes] Save variable expand state while stepping #3269

jasonLaster opened this issue Jul 5, 2017 · 7 comments

Comments

@jasonLaster
Copy link
Contributor

We used to support keeping variable expand states while stepping. We dropped support earlier when we realized we were keeping stale data. We should look into re-adding support though.

@bgrins
Copy link
Contributor

bgrins commented Jul 21, 2017

Same thing with Watch Expressions. @jasonLaster would you like me to file a new issue for that or do you expect they would be handled here?

@bgrins
Copy link
Contributor

bgrins commented Jul 21, 2017

STR:

Load data:text/html,<script>var obj = { a: { b: 'c' } }; document.onclick = function() { debugger; for (var i = 0; i < 3; i++) ; } </script>

Open debugger
Click anywhere to pause
Expand "Scopes" -> Window -> obj
Step

Expected:
obj remains expanded

Actual:
Window gets collapsed

@bgrins
Copy link
Contributor

bgrins commented Jul 21, 2017

stepping-watch

Gif of the behavior with watch expressions

@jasonLaster
Copy link
Contributor Author

This might be a nice bug to re-explore.

I think step one is to talk to the console folks and see what we did in the old debugger. variable-view.jsm

@Standard8
Copy link

Does this issue cover the scopes as well? One of my biggest issues at the moment is when you're trying to watch a variable that is in one of the upper scopes, and you have to keep expanding it. IMHO that's a bug, rather than an enhancement.

@jasonLaster
Copy link
Contributor Author

haha - yeah i can see that too. I'm moving this to the backlog so we'll get to it in the next sprint or two.

@janodvarko
Copy link
Member

This issue is still nicely reproducible.

There are two places that need to be fixed:

  • Watch Expressions
  • Scopes
    (additional bug might be reported)

Note that switching to another (callstack) frame and back also resets the expanded state.
It's not clear how long the state should be stored. E.g. resuming JS and breaking at the same state the next day should also work?

Honza

@janodvarko janodvarko mentioned this issue Oct 12, 2018
25 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants