This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Cleanup build options #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasonLaster
commented
Jan 9, 2017
jasonLaster
commented
- switch to using an implicit bundleName over just using "bundle" or passing in an explicit one
- drop library name
- cleanup some code
nchevobbe
previously requested changes
Jan 10, 2017
| res.send(Mustache.render(tplFile, { | ||
| isDevelopment: isDevelopment(), | ||
| dir: getValue("dir") || "ltr", | ||
| bundleName: getValue("title").toLocaleLowerCase() || "bundle", |
There was a problem hiding this comment.
wouldn't it break if the config does not specify a title ?
There was a problem hiding this comment.
@nchevobbe The or should fall back to bundle.
There was a problem hiding this comment.
I was thinking getValue("title") is undefined if there isn't a title entry in the configuration, hence, doing .toLocaleLowerCase() on undefined would have throw.
I'll check and open a PR if there's such issue
jasonLaster
force-pushed
the
build-opts
branch
from
a71a9fe
to
2030030
Compare
|
sorry if i missed something @nchevobbe |
nope, sounds good, I didn't saw that you fixed it :) |
nchevobbe
added a commit
that referenced
this pull request
Jun 5, 2017
allow window rep title customization from grip
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.