Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node v12 #2580

Closed
julienw opened this issue Jun 4, 2020 · 1 comment
Closed

Upgrade to node v12 #2580

julienw opened this issue Jun 4, 2020 · 1 comment
Labels
code maintenance Issues that are not user facing, but are related the technical debt with the code itself good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task

Comments

@julienw
Copy link
Contributor

julienw commented Jun 4, 2020

Node v12 is the new LTS, we should upgrade. Because this is used only for the dev environment I think this will be straightforward.

Some related things to change are:

  • remove the NODE_OPTIONS=--experimental-worker things because it's not experimental anymore
  • TextDecoder and TextEncoder are now globals so we can remove the code in some of our tests that makes them global
  • change 10.15 to 12 in .circleci/config.yml. This is also where the value is taken in bin/pre-install.js.
  • While we're here, I was thinking we can at least try to switch to the more lightweight circleci images cimg/node:12 instead of circleci/node:12, see if this works. This will require change the code in bin/pre-install.js to extract the node version.
  • change it also in appveyor.yml

Any taker?

@julienw julienw added code maintenance Issues that are not user facing, but are related the technical debt with the code itself good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task labels Jun 4, 2020
@duncanjbain
Copy link
Contributor

Hi @julienw, I’ll take this up! Will get a PR in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code maintenance Issues that are not user facing, but are related the technical debt with the code itself good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task
Projects
None yet
Development

No branches or pull requests

2 participants