Show indicators for markers in the thread timeline

[mstange]

No description provided.

[gregtatum]

I'm not sure what this issue is getting at. Isn't this already implemented?

[mstange]

The thing that we already have shows "tracing" markers (i.e. markers with a start time and an end time), but not point-of-time markers. For point-of-time markers, the old cleopatra would overlay vertical lines onto the ThreadStackGraph, and every line had a piece of text with the marker name attached to it.

I've written the start of a component that implements this (ThreadMarkerOverlay), but it's not being used, and I'm not sold on the idea of squeezing even more information into the stuff at the top.
We do need to display it somewhere, though. Mike Conley is the person who asks me about this the most.

Examples for such markers are the "Invalidate" and "Bailout" markers from JS (too many to be useful), "AsyncTabSwitch:Start", "AsyncTabSwitch:Finish", "AsyncTabSwitch:SpinnerShown", "AsyncTabSwitch:SpinnerHidden", and some others that you can find with these code searches.

[gregtatum]

Seems like a good candidate for moving to the Timeline.

[gregtatum]

Closing this for now, it's old and I'm not sure what we want to do here.

[julienw]

I believe we can already achieve this by clicking on a marker as it will add the selection's vertical line. (we need to fix the alignment bug of course)