Update to marker-timing.js

[ael-mas]

fixing #1827

[codecov]

Codecov Report

Merging #1830 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
- Coverage   84.09%   84.07%   -0.02%     
==========================================
  Files         179      179              
  Lines       12435    12437       +2     
  Branches     3067     3065       -2     
==========================================
  Hits        10457    10457              
- Misses       1798     1800       +2     
  Partials      180      180

Impacted Files	Coverage Δ
src/profile-logic/marker-timing.js	88.88% <0%> (-5.23%)	⬇️
src/components/js-tracer/Settings.js	100% <0%> (ø)	⬆️
src/app-logic/url-handling.js	82.24% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3500ec8...20635fa. Read the comment docs.

[ael-mas]

Could someone help me understand what the codecov tests mean when they're failing? I'm looking at the details and can't seem to wrap my head around what's happening.

[canova]

hey @ael-mas, thanks for the PR! It looks good to me.

For the codecov, it's not required to pass to merge the PR. Generally it's good to add some tests when you change something and that tool helps us to understand if we are missing to add some tests. Currently you added a new branch and that branch is not covered by test(that means while running all the tests we are not going inside that branch and we are not executing these codes). But before this patch we had no specific tests for this function as well and other paths are also not covered so it's okay to land this.