Join GitHub today
Update to marker-timing.js #1830
@@ Coverage Diff @@ ## master #1830 +/- ## ========================================== - Coverage 84.09% 84.07% -0.02% ========================================== Files 179 179 Lines 12435 12437 +2 Branches 3067 3065 -2 ========================================== Hits 10457 10457 - Misses 1798 1800 +2 Partials 180 180
canaltinova left a comment
hey @ael-mas, thanks for the PR! It looks good to me.
For the codecov, it's not required to pass to merge the PR. Generally it's good to add some tests when you change something and that tool helps us to understand if we are missing to add some tests. Currently you added a new branch and that branch is not covered by test(that means while running all the tests we are not going inside that branch and we are not executing these codes). But before this patch we had no specific tests for this function as well and other paths are also not covered so it's okay to land this.