Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the responsiveness field name in gecko and processed profile format #2303

Merged
merged 3 commits into from Nov 13, 2019

Conversation

canova
Copy link
Member

@canova canova commented Nov 11, 2019

This is the front-end changes of Bug 1595482.

cc @jesup

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #2303 into master will decrease coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
- Coverage   86.13%   86.11%   -0.02%     
==========================================
  Files         204      204              
  Lines       15004    15019      +15     
  Branches     3766     3772       +6     
==========================================
+ Hits        12923    12934      +11     
- Misses       1909     1913       +4     
  Partials      172      172
Impacted Files Coverage Δ
src/profile-logic/profile-data.js 93.91% <100%> (+0.03%) ⬆️
src/profile-logic/import/chrome.js 93.28% <100%> (ø) ⬆️
src/profile-logic/marker-data.js 89.93% <100%> (+0.06%) ⬆️
src/profile-logic/comparison.js 91.91% <100%> (ø) ⬆️
src/test/fixtures/profiles/processed-profile.js 97.97% <100%> (ø) ⬆️
src/profile-logic/js-tracer.js 88.98% <100%> (ø) ⬆️
src/profile-logic/data-structures.js 94.73% <66.66%> (-5.27%) ⬇️
src/profile-logic/process-profile.js 93.63% <71.42%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7807031...2f05ded. Read the comment docs.

@canova canova changed the title Change the responsiveness field name in gecko profile format and keep a meta field about it Change the responsiveness field name in gecko and processed profile format Nov 12, 2019
Copy link
Member Author

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @gregtatum, updated the code. Could you take a look at it now?

src/profile-logic/comparison.js Show resolved Hide resolved
src/profile-logic/data-structures.js Show resolved Hide resolved
src/profile-logic/js-tracer.js Show resolved Hide resolved
src/profile-logic/marker-data.js Outdated Show resolved Hide resolved
src/test/store/profile-view.test.js Show resolved Hide resolved
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the earlier changes. This looks good to me. I left an optional comment on the throws, but I'll leave it up to you, as the author, plus a few smaller comments.

src/profile-logic/data-structures.js Show resolved Hide resolved
src/profile-logic/import/chrome.js Outdated Show resolved Hide resolved
src/profile-logic/marker-data.js Outdated Show resolved Hide resolved
src/profile-logic/process-profile.js Outdated Show resolved Hide resolved
src/profile-logic/profile-data.js Outdated Show resolved Hide resolved
src/types/gecko-profile.js Outdated Show resolved Hide resolved
src/types/profile.js Show resolved Hide resolved
@canova canova merged commit 552a5ca into firefox-devtools:master Nov 13, 2019
@canova canova deleted the new-responsiness branch November 13, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants