Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deploy preview] Inline callstacks demo #2556

Closed
wants to merge 13 commits into from
Closed

[Deploy preview] Inline callstacks demo #2556

wants to merge 13 commits into from

Commits on Jun 8, 2021

  1. Hack queryAPI support into the thing.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2341d83 View commit details
    Browse the repository at this point in the history

  2. Factor out this function.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2ef1c30 View commit details
    Browse the repository at this point in the history

  3. Refactor some more.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1e416f1 View commit details
    Browse the repository at this point in the history

  4. Properly do fallback between symbol server, query API and getSymbolTa… 

    …ble.
    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    36ef2e3 View commit details
    Browse the repository at this point in the history

  5. Rename types to ...V5.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5bacb84 View commit details
    Browse the repository at this point in the history

  6. Add type definitions for the V6 API result shape.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    9c076b3 View commit details
    Browse the repository at this point in the history

  7. Request symbols from /v6a1 and then fall back to /v5.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    792f53c View commit details
    Browse the repository at this point in the history

  8. Propagate inline information to symbolication.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f1bb2d1 View commit details
    Browse the repository at this point in the history

  9. Change the processed profile format in anticipation of inline callsta… 

    …cks.
    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    71088db View commit details
    Browse the repository at this point in the history

  10. Resolve inline callstacks during symbolication.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    38ce7f4 View commit details
    Browse the repository at this point in the history

  11. Add a sourceFramesInlinedIntoSymbol column to the CallNodeTable.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    cd69547 View commit details
    Browse the repository at this point in the history

  12. Add a badge to the call tree for inlined functions.

    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ab70786 View commit details
    Browse the repository at this point in the history

  13. Adjust return addresses. 

    For return addresses, look up addresses minus one byte, to fall into the
previous instruction. This is necessary to get accurate line information
and accurate inline stacks.
The stack leaf (instruction pointer) must not be adjusted.
As a result, this is a rather invasive process because the stack table
needs major surgery to account for new stacks.
    @mstange
    mstange committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2edd26e View commit details
    Browse the repository at this point in the history