Remove animation if user prefers reduced motion #2586
Conversation
… downwards translation
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
==========================================
+ Coverage 86.55% 86.57% +0.01%
==========================================
Files 217 217
Lines 17168 17079 -89
Branches 4433 4405 -28
==========================================
- Hits 14860 14786 -74
+ Misses 2112 2099 -13
+ Partials 196 194 -2
Continue to review full report at Codecov.
|
|
Looks great to me! I've also tested the new animation and I think it looks good. It has a bit of an initial opening delay, but that's due to the drop shadow SVG filter and is caused by a performance bug in Firefox, and not something that we need to fix in the profiler. Greg, can you review? I suggested most of this implementation so I think this could use another pair of eyes. |
|
Thanks, yeah this works for me. With the delay the animation is almost hard to see. I wonder if it's worth making it faster by removing the SVG filter trick. I did a box shadow and it was a lot snappier. I also manually tested the reduced motion, and it worked on my end. |
|
I'm fine with using a box-shadow. It'll look a bit odd around the arrow but it should be good enough. |
|
Thank you for advising, Markus and Greg :) Happy to contribute more in the future. |
5a83ee2
into
firefox-devtools:master
Description
This PR addresses issue #2509.
Per the guidance of @mstange, we are making a revision that makes sure there is no animation if the
prefers-reduced-motionis active; otherwise, the animation is going to be a simple downwards translation.