Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for inline stacks #3556

Merged
merged 10 commits into from Nov 30, 2021
Merged

Add support for inline stacks #3556

merged 10 commits into from Nov 30, 2021

Commits on Nov 30, 2021

  1. Add an inlineDepth column to the frame table. 

    This column will be needed for inline call stack symbolication.
    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    d8b77c2 View commit details
    Browse the repository at this point in the history

  2. Add inlines field to response JSON definition.

    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    c18e99d View commit details
    Browse the repository at this point in the history

  3. Propagate inline information to symbolication.

    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    b4fe808 View commit details
    Browse the repository at this point in the history

  4. Allow symbolication to replace a single func with multiple funcs in a… 

    …ny call paths that are stored in the redux state.
    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    09873e7 View commit details
    Browse the repository at this point in the history

  5. Remove any existing inline frame stack nodes at the beginning of symb… 

    …olication.
    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    f3d7100 View commit details
    Browse the repository at this point in the history

  6. Create the new frameTable earlier.

    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    c902564 View commit details
    Browse the repository at this point in the history

  7. Resolve inline frames during symbolication. 

    This patch is the last symbolication-related change in this series.
With this patch, inline stacks are now fully supported.
    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    adceb90 View commit details
    Browse the repository at this point in the history

  8. Add a sourceFramesInlinedIntoSymbol column to the CallNodeTable.

    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    5c678c4 View commit details
    Browse the repository at this point in the history

  9. Add a badge to the call tree for inlined functions. 

    This answers the question "Why wasn't this inlined!?" which some
people who are used to the old inline-less call tree might have.
    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    f754f68 View commit details
    Browse the repository at this point in the history

  10. Add some test for inline symbolication.

    @mstange
    mstange committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    02e1fad View commit details
    Browse the repository at this point in the history