✨ let the path seperator be configurable for import _category

firegento · Sep 12, 2017 · fc1d5c2 · fc1d5c2
1 parent 9943113
commit fc1d5c2
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/Helper/Config.php b/Helper/Config.php
@@ -16,6 +16,7 @@ class Config extends \Magento\Framework\App\Helper\AbstractHelper
     const XML_PATH_VALIDATION_STRATEGY    = 'fastsimpleimport/default/validation_strategy';
     const XML_PATH_ALLOWED_ERROR_COUNT    = 'fastsimpleimport/default/allowed_error_count';
     const XML_PATH_IMPORT_IMAGES_FILE_FIR = 'fastsimpleimport/default/import_images_file_dir';
+    const XML_PATH_CATEGORY_PATH_SEPERATOR = 'fastsimpleimport/default/category_path_seperator';
 
     /**
      * @param \Magento\Framework\App\Helper\Context $context
@@ -26,6 +27,10 @@ public function __construct(
         parent::__construct($context);
     }
 
+    public function getCategoryPathSeperator() {
+        return $this->scopeConfig->getValue(self::XML_PATH_CATEGORY_PATH_SEPERATOR, ScopeInterface::SCOPE_STORE);
+    }
+
     /**
      * @return string
      */

diff --git a/Model/Import/Category.php b/Model/Import/Category.php
@@ -516,7 +516,7 @@ protected function initCategories()
                     $this->categoriesWithRoots[$rootCategoryName] = [];
                 }
 
-                $index = $this->implodeEscaped('/', $path);
+                $index = $this->implodeEscaped($this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR), $path);
                 $this->categoriesWithRoots[$rootCategoryName][$index] = [
                     'entity_id' => $category->getId(),
                     CategoryModel::KEY_PATH => $category->getData(CategoryModel::KEY_PATH),
@@ -557,7 +557,7 @@ protected function implodeEscaped($glue, array $array)
         foreach ($array as $value) {
             $newArray[] = str_replace($glue, '\\' . $glue, $value);
         }
-        return implode('/', $newArray);
+        return implode($this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR), $newArray);
     }
 
     /**
@@ -805,8 +805,9 @@ protected function reindexUpdatedCategories($categoryId)
             if ($storeId == 0) {
                 continue;
             }
+
             $category = $this->categoryRepository->get($categoryId, $storeId);
-            //$category->setStoreId($storeId);
+
             $urlRewrites = $this->categoryUrlRewriteGenerator->generate($category, true);
             $this->urlPersist->replace($urlRewrites);
         }
@@ -1052,7 +1053,7 @@ protected function getCategoryName($rowData)
             return $rowData[CategoryModel::KEY_NAME];
         }
 
-        $categoryParts = $this->explodeEscaped('/', $rowData[self::COL_CATEGORY]);
+        $categoryParts = $this->explodeEscaped($this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR), $rowData[self::COL_CATEGORY]);
         return end($categoryParts);
     }
 
@@ -1094,9 +1095,9 @@ protected function getParentCategory($rowData)
             // if _category eq. name then we don't have parents
             $parent = false;
         } else {
-            $categoryParts = $this->explodeEscaped('/', $rowData[self::COL_CATEGORY]);
+            $categoryParts = $this->explodeEscaped($this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR), $rowData[self::COL_CATEGORY]);
             array_pop($categoryParts);
-            $parent = $this->implodeEscaped('/', $categoryParts);
+            $parent = $this->implodeEscaped($this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR), $categoryParts);
         }
 
         if ($parent) {

diff --git a/Model/Importer.php b/Model/Importer.php
@@ -69,6 +69,7 @@ public function __construct(
             'validation_strategy' => $this->configHelper->getValidationStrategy(),
             'allowed_error_count' => $this->configHelper->getAllowedErrorCount(),
             'import_images_file_dir' => $this->configHelper->getImportFileDir(),
+            'category_path_seperator' => $this->configHelper->getCategoryPathSeperator(),
             '_import_multiple_value_separator' =>  Import::DEFAULT_GLOBAL_MULTI_VALUE_SEPARATOR
         ];
     }

diff --git a/etc/adminhtml/system.xml b/etc/adminhtml/system.xml
@@ -36,6 +36,9 @@
                     <label>Ignore duplicates</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                 </field>
+                <field id="category_path_seperator" translate="label" type="text" sortOrder="70" showInDefault="1" showInWebsite="0" showInStore="0">
+                    <label>Category path seperator</label>
+                </field>
             </group>
         </section>
     </system>

diff --git a/etc/config.xml b/etc/config.xml
@@ -14,6 +14,7 @@
                 <entity>catalog_product</entity>
                 <validation_strategy>validation-stop-on-errors</validation_strategy>
                 <allowed_error_count>10</allowed_error_count>
+                <category_path_seperator>/</category_path_seperator>
             </default>
         </fastsimpleimport>
         <system>