Mail Template for Newsletter Confirmation broken?

[winkelsdorf]

I am currently testing magento 1.9.1.0 with rwd template and mageSetup (development branch, current as of now).

Can somebody confirm that the Template "Newsletter Anmeldung Bestätigung (de_DE)" works flawlessly?

For some reason the call to magesetup/imprint_content made it into the Action-Button-class Table:

            <table cellspacing="0" cellpadding="0" class="action-button" >
[..]
                        <tr>
                            <td>
                                {{block type="magesetup/imprint_content" template="magesetup/imprint/email_footer.phtml"}}
                            </td>
                        </tr>

                    </table>

This happens in all language templates setup for the newsletter confirmation (using EN, DE, FR, IT).

This leads to a broken design of the confirmation mail. Currently I am if this is mageSetup or magento rwd related.

[winkelsdorf]

Verified that the footer is actually created by mageSetup via the settings in /app/code/community/FireGento/MageSetup/etc/[lang]/email.xml.

Regarding the newsletter subscription confirmation mail the position of the added <footer> block is added to the wrong table.

Manually correcting the template in backend as workaround:

<table cellspacing="0" cellpadding="0" class="action-button">
    <tr>
        <td>
            <a href="{{var subscriber.getConfirmationLink()}}"><span>Newsletter-Anmeldung bestätigen</span></a>
        </td>
    </tr>
</table>
<table cellspacing="0" cellpadding="0">
    <tr>
        <td>
            {{block type="magesetup/imprint_content" template="magesetup/imprint/email_footer.phtml"}}
        </td>
    </tr>   
</table>

Edit: btw the Blue Button's style should give a little padding to the inner text..

[winkelsdorf]

Hmm, I currently see no way of easily fixing this..

The footer is added in email.xml via

<email_footers>
                <default>
                    <footer>
                        <![CDATA[
                        <tr>
                            <td>
                                {{block type="magesetup/imprint_content" template="magesetup/imprint/email_footer.phtml"}}
                            </td>
                        </tr>
                        ]]>
                    </footer>

which is a general attachment.

Is it possible to define an override just for the newsletter confirmation template? Checking email.php now.

I will check later today if other templates are broken too and post back here.

[akkermanronald]

Hi Winkelsdorf,
Did you fix this yourself or find a workaround?
Regards
Ronald

[winkelsdorf]

Hi Ronald,

what, that issue is still not fixed slightly over a year after?

To answer your question: Unfortunately not, due to many many problems with the quality and maintainability of magento itself (< v2 at that time, can't speak of v2) and the available working and not working extensions, we decided to switch to a commercial and productive-ready solution for that particular customer. I am sorry but I cannot name it because of an NDA.

To make it clear, I am not speaking of firegento-magesetup being part of the problem. They are trying their best to avoid some magento pitfalls.

But working on scalability, custom modules and themes is enough. Having to work on other people's source and the framework/core of a shop system itself is too much (time needed for fixes/adjustments vs. license costs for commercial or SaaS solutions).

Good luck!

Regards,
Frederik

[sprankhub]

I can confirm this issue, but it is quite hard to fix. We add the footer blocks before the penultimate </table> tag in FireGento_MageSetup_Model_Setup_Email::_addFooterBlocks. This is usually correct, but unfortunately, the format of the newsletter_subscr_confirm.html is different. We would have to add the blocks right before the LAST </table> tag in this case. I do not have a good idea for a fix. But you can of course easily fix the mail template under System > Transactional Emails. Simply move the MageSetup block to right before the last </table> tag.