Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast activation error handling #22

Open
ktsaou opened this issue Mar 12, 2014 · 4 comments
Open

fast activation error handling #22

ktsaou opened this issue Mar 12, 2014 · 4 comments

Comments

@ktsaou
Copy link
Member

ktsaou commented Mar 12, 2014

In fast activation mode, if it fails it should at least print the offending line that broke the firewall.

iptables-restore does provide the line number.

ktsaou added a commit that referenced this issue Mar 12, 2014
@ktsaou
Copy link
Member Author

ktsaou commented Mar 12, 2014

I have just greped the line.

Normaly we should have better error control by detecting the configuration command that generated the wrong line. This requires a lot of re-writing though.

@ktsaou ktsaou closed this as completed Mar 12, 2014
@ktsaou
Copy link
Member Author

ktsaou commented Mar 12, 2014

@philwhineray I have not tested this in ipv6.
Could you please check it?

@ktsaou ktsaou reopened this Mar 12, 2014
ktsaou added a commit that referenced this issue Mar 13, 2014
@philwhineray
Copy link
Member

I can confirm the offending line is correctly reported with an IPv6 error too.

To get the original line can we add comments to the generated iptables-restore file linking back to the original firehol.conf line?

@ktsaou
Copy link
Member Author

ktsaou commented May 17, 2014

I guess comments will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants