Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always build feature complete #15

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

psychocrypt
Copy link
Collaborator

@psychocrypt psychocrypt commented Apr 8, 2017

Change

  • throw an error if a compile dependancy is not fullfilled
  • add options to disable hard compile dependancies

close #14

Note

I used the names *_REQUIRED to mirroring the fact that if someone disable the requirement of a dependancy it is still build with those if they can be found.

Expert Option

All libraries which are searched with cmake find_package can be disabled with CMAKE_DISABLE_FIND_PACKAGE_<PackageName>. If for example OpenSSL is disabled the error is thrown that the used needs to disable the requirement.
example how to disable OpenSSL also if the library is available: cmake ../xmr-stak-nvidia/ -DCMAKE_DISABLE_FIND_PACKAGE_OpenSSL=ON -DOpenSSL_REQUIRED=OFF

Test

  • compiled test
  • runtime test

- throw an error if a compile dependancy is not fullfilled
- add options to disable hard compile dependancies
@fireice-uk
Copy link
Owner

Thanks!

@fireice-uk fireice-uk merged commit 24892bf into fireice-uk:dev Apr 8, 2017
@psychocrypt psychocrypt deleted the topic-fullFeatureBuild branch April 10, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants