fix default interleave value #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireice-uk
approved these changes
Dec 3, 2018
fireice-uk
reviewed
Dec 3, 2018
xmrstak/backend/amd/jconf.cpp
Outdated
| printer::inst()->print_msg(L0, "ERROR: interleave must be a number"); | ||
| return false; | ||
| } | ||
| else if((int)interleave->GetInt64() < 0 || (int)interleave->GetInt64() > 100) |
There was a problem hiding this comment.
It you want to have a plain int here you can simply just use GetInt()
The default value for interleave was wrongly set to 50. Remove the value and take the devault from the default constructor instead of side channeling it from the json parser.
psychocrypt
force-pushed
the
fix-defaultInterleave
branch
from
2f05bd6
to
05b4976
Compare
Merged
gnagel
pushed a commit
to gnagel/xmr-stak
that referenced
this pull request
Mar 23, 2019
…eave fix default interleave value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for interleave was wrongly set to 50.
Remove the value and take the default from the default constructor instead of side channeling it from the json parser.