Support of CryptoNight v8 ReverseWaltz #2261

EDDragonWolf · 2019-02-26T19:13:08Z

Added support of CryptoNight v8 Reverse Waltz (named cryptonight_v8_reversewaltz here) - equal to CryptoNight v8 but with 3/4 iterations of CryptoNight v8 and with reversed shuffle operation

We plan to use CryptoNight v8 Reverse Waltz as new PoW algorithm for Graft (graft-project/GraftNetwork#234).

…rsewaltz, reverse_waltz or graft)

psychocrypt · 2019-02-26T21:00:10Z

xmrstak/jconf.cpp

@@ -118,7 +119,8 @@ xmrstak::coin_selection coins[] = {
 	{ "stellite",                {POW(cryptonight_v8_half)},   {POW(cryptonight_monero_v8)}, nullptr },
 	{ "turtlecoin",              {POW(cryptonight_turtle), 6u,POW(cryptonight_aeon)}, {POW(cryptonight_aeon)}, nullptr },
 	{ "plenteum",			     {POW(cryptonight_turtle)},    {POW(cryptonight_turtle)},    nullptr },
-	{ "zelerius",                {POW(cryptonight_v8_zelerius), 7, POW(cryptonight_monero_v8)},   {POW(cryptonight_monero_v8)}, nullptr }
+	{ "zelerius",                {POW(cryptonight_v8_zelerius), 7, POW(cryptonight_monero_v8)},   {POW(cryptonight_monero_v8)}, nullptr },
+	{ "reverse_waltz",           {POW(cryptonight_v8_reversewaltz)}, {POW(cryptonight_monero_v8)}, "mining.grftpool.com:3333" }


please rename reverse_waltz to cryptonight_v8_reversewaltz and put it into alphabetic order. cryptonight_v8_reversewaltz is the name yo asl oput in to README.txt

Please also remove the inactive pool.

cryptonight_v8_reversewaltz is already present, moved it into alphabetic order.

removed reverse_waltz. I added it as another alias, however, if I correctly understood, you add as additional aliases only coin names, so I removed it.

moved cryptonight_v8_reversewaltz in README.txt and pools.tpl into alphabetic order. Sorry, I didn't notice it before.
Thanks.

psychocrypt · 2019-02-26T21:02:42Z

xmrstak/jconf.cpp

 	{ "freehaven",               {POW(cryptonight_superfast)}, {POW(cryptonight_monero_v8)}, nullptr },
-	{ "graft",                   {POW(cryptonight_monero_v8)}, {POW(cryptonight_monero_v8)}, nullptr },
+	{ "graft",                   {POW(cryptonight_v8_reversewaltz)}, {POW(cryptonight_monero_v8)}, "mining.grftpool.com:3333" },


Please change to {POW(cryptonight_v8_reversewaltz), <forkblockversion>, POW(cryptonight_monero_v8)}, {POW(cryptonight_monero_v8)} to allow to fork on a given block height. must be replaced with the block version where the coin is forking.

Please remove the pool sugestion or add an active pool. If you add an active pool please use not th elargest.

modified "graft" record as you asked;

added fork block version - 12;

removed pool suggestion. It is active since we maintain it, but it isn't the most popular Graft mining pool and, unfortunately, it has a zero hash rate.
Thanks.

jagerman · 2019-02-28T15:32:56Z

xmrstak/backend/amd/amd_gpu/opencl/cryptonight.cl

@@ -794,6 +795,17 @@ __kernel void JOIN(cn1,ALGO) (__global uint4 *Scratchpad, __global ulong *states
 		}
 #endif

+#if(ALGO == cryptonight_v8_reversewaltz)


One slight cleanup here:

#endif #if(ALGO ==

would be better written as:

#elif(ALGO ==

Makes sense. Thanks.
Done.

Actually I think this code could be made simpler still if you did some #define trickery on the declaration, like this:

// (earlier) #if(ALGO == cryptonight_monero_v8) # define CNV8_CHUNK1_INTO chunk1 # define CNV8_CHUNK3_INTO chunk3 #elif(ALGO == cryptonight_v8_reversewaltz) # define CNV8_CHUNK1_INTO chunk3 # define CNV8_CHUNK3_INTO chunk1 #endif

Then you can ditch the second code block entirely and change the first to:

#if(ALGO == cryptonight_monero_v8 || ALGO == cryptonight_v8_reversewaltz) { ulong2 CNV8_CHUNK1_INTO = as_ulong2(SCRATCHPAD_CHUNK(1)); ulong2 chunk2 = as_ulong2(SCRATCHPAD_CHUNK(2)); ulong2 CNV8_CHUNK3_INTO = as_ulong2(SCRATCHPAD_CHUNK(3)); SCRATCHPAD_CHUNK(1) = as_uint4(chunk3 + ((ulong2 *)(b_x + 1))[0]); SCRATCHPAD_CHUNK(2) = as_uint4(chunk1 + ((ulong2 *)b_x)[0]); SCRATCHPAD_CHUNK(3) = as_uint4(chunk2 + ((ulong2 *)a)[0]); } #endif

and then... (continued in next comment)

Yes, but it can complicate reading of the code. Also, I wanted to minimize my changes, so I tried to leave original implementation as close to original as I could. However, if @psychocrypt and @fireice-uk agree with your proposal, I'll replace it using defines.

jagerman · 2019-02-28T15:49:45Z

xmrstak/backend/nvidia/nvcc_code/cuda_core.cu

@@ -370,6 +370,22 @@ __global__ void cryptonight_core_gpu_phase2_double(
 			myChunks[ idx1 ^ 6 + sub ] = chunk2 + ax0;
 		}

+		if(ALGO == cryptonight_v8_reversewaltz)


Makes sense. Thanks.
Done.

psychocrypt · 2019-03-03T15:01:47Z

Please provide the test pool address and a wallet address I can use for testing

…ersewaltz

EDDragonWolf · 2019-03-05T22:48:56Z

@psychocrypt
Sorry for the delay, we had a big delay with HF on testnet, it forked only now
testnet mining pool - http://3.83.140.241/
if you need some testnet wallet addresses:
FAaegMUw5YV9GcwNGwJsyLdc1jkVRnNWcX3zEd5e1Nmci8HmGQGt3J3NUjeWi19WQi9t52mAwxHCXUSkcufmmU7CMVpjACG
FB4ZejF4V3w8qhRgxQVENyKc8aCmgP4whaUQhZuw7zwnb5rdgEKFq1G5gbGnhUCBXKPHF3bYLDqZD5e7JG7i2Wf3LwNmXDu
F8WjfGHDBqkhtSy674bz1tjaBooPnFEgvF92ooYbrCCNCagzbT8SxogS2PiW3LKuEMhGrE6V2YJP3CgLeENd53JZLExetb6

jagerman · 2019-03-05T23:47:06Z

https://testnet.graft.community is also up and running.

jagerman · 2019-03-06T02:44:32Z

xmrstak/backend/amd/amd_gpu/opencl/cryptonight.cl

@@ -30,6 +30,7 @@ R"===(
 #define cryptonight_superfast 12
 #define cryptonight_gpu 13
 #define cryptonight_conceal 14
+#define cryptonight_v8_reversewaltz 15


This needs to be 17, not 15, to agree with the value in xmrstak/backend/cryptonight.hpp

Okay. Fixed. Thanks, @jagerman.

jagerman · 2019-03-06T02:47:41Z

xmrstak/backend/amd/amd_gpu/opencl/cryptonight.cl

+				chunk3 = chunk1;
+				chunk1 = chunk_tmp;
+			}
+#endif
 			SCRATCHPAD_CHUNK(1) = as_uint4(chunk3 + ((ulong2 *)(b_x + 1))[0]);
 			SCRATCHPAD_CHUNK(2) = as_uint4(chunk1 + ((ulong2 *)b_x)[0]);


The swap above this is not nice: better to remove it and #ifdef the assignment as:

#if(ALGO == cryptonight_v8_reversewaltz) SCRATCHPAD_CHUNK(1) = as_uint4(chunk1 + ((ulong2 *)(b_x + 1))[0]); SCRATCHPAD_CHUNK(2) = as_uint4(chunk3 + ((ulong2 *)b_x)[0]); #else SCRATCHPAD_CHUNK(1) = as_uint4(chunk3 + ((ulong2 *)(b_x + 1))[0]); SCRATCHPAD_CHUNK(2) = as_uint4(chunk1 + ((ulong2 *)b_x)[0]); #endif

Agree with you. Fixed. Thanks.

rebased version of fireice-uk#2261 Added support of CryptoNight v8 Reverse Waltz (named cryptonight_v8_reversewaltz here) - equal to CryptoNight v8 but with 3/4 iterations of CryptoNight v8 and with reversed shuffle operation We plan to use CryptoNight v8 Reverse Waltz as new PoW algorithm for Graft (graft-project/GraftNetwork#234).

psychocrypt · 2019-03-07T20:51:40Z

thx for the pull request I rebased it in #2282

rebased version of fireice-uk#2261 Added support of CryptoNight v8 Reverse Waltz (named cryptonight_v8_reversewaltz here) - equal to CryptoNight v8 but with 3/4 iterations of CryptoNight v8 and with reversed shuffle operation We plan to use CryptoNight v8 Reverse Waltz as new PoW algorithm for Graft (graft-project/GraftNetwork#234).

Added support of CryptoNight v8 ReverseWaltz (aka cryptonight_v8_reve…

4457b60

…rsewaltz, reverse_waltz or graft)

psychocrypt requested review from psychocrypt and fireice-uk February 26, 2019 20:54

psychocrypt added the currency Add/Modify a Currency label Feb 26, 2019

psychocrypt requested changes Feb 26, 2019

View reviewed changes

Fixed format of CryptoNight ReverseWaltz configuration

4bfc9d3

EDDragonWolf force-pushed the reversewaltz branch from dc3bbfb to 4bfc9d3 Compare February 27, 2019 17:52

jagerman reviewed Feb 28, 2019

View reviewed changes

Fixed if-else condition for OpenCL and CUDA implementation

c9db128

EDDragonWolf force-pushed the reversewaltz branch from cbd5a84 to c9db128 Compare February 28, 2019 18:17

Merge branch 'dev' of https://github.com/fireice-uk/xmr-stak into rev…

2f41efd

…ersewaltz

jagerman reviewed Mar 6, 2019

View reviewed changes

Fixed AMD support of CryptoNight v8 ReverseWaltz

d10dafc

EDDragonWolf force-pushed the reversewaltz branch from 219b6ed to d10dafc Compare March 6, 2019 08:56

psychocrypt mentioned this pull request Mar 7, 2019

Support of CryptoNight v8 ReverseWaltz #2282

Merged

psychocrypt closed this Mar 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support of CryptoNight v8 ReverseWaltz #2261

Support of CryptoNight v8 ReverseWaltz #2261

EDDragonWolf commented Feb 26, 2019

psychocrypt Feb 26, 2019

psychocrypt Feb 26, 2019

EDDragonWolf Feb 27, 2019 •

edited

Loading

psychocrypt Feb 26, 2019

EDDragonWolf Feb 27, 2019

jagerman Feb 28, 2019

EDDragonWolf Feb 28, 2019

jagerman Feb 28, 2019 •

edited

Loading

EDDragonWolf Feb 28, 2019

jagerman Feb 28, 2019

EDDragonWolf Feb 28, 2019

psychocrypt commented Mar 3, 2019

EDDragonWolf commented Mar 5, 2019 •

edited

Loading

jagerman commented Mar 5, 2019

jagerman Mar 6, 2019

EDDragonWolf Mar 6, 2019

jagerman Mar 6, 2019 •

edited

Loading

EDDragonWolf Mar 6, 2019

psychocrypt commented Mar 7, 2019

Support of CryptoNight v8 ReverseWaltz #2261

Support of CryptoNight v8 ReverseWaltz #2261

Conversation

EDDragonWolf commented Feb 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EDDragonWolf Feb 27, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jagerman Feb 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

psychocrypt commented Mar 3, 2019

EDDragonWolf commented Mar 5, 2019 • edited Loading

jagerman commented Mar 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jagerman Mar 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

psychocrypt commented Mar 7, 2019

EDDragonWolf Feb 27, 2019 •

edited

Loading

jagerman Feb 28, 2019 •

edited

Loading

EDDragonWolf commented Mar 5, 2019 •

edited

Loading

jagerman Mar 6, 2019 •

edited

Loading