fix singletons #2529
Merged
fix singletons #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can not implement clean image book singletons (windows issues with shared libraries) we used a hierarchical to "emulate" singletons. During the creation race consitions are possible. THis PR will handle the raceconditions with a mutex, since we pass the creation of a singleton creation only onse we have no performance issue.
fireice-uk
approved these changes
Sep 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can not implement clean image book singletons (windows
issues with shared libraries) we used a hierarchical to "emulate"
singletons. During the creation race conditions are possible.
This PR will handle the race-conditions with a mutex, since we pass the
creation of a singleton creation only ones we have no performance issue.