fix windows compile and broken aeon #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix windows linker error during compile - fix wrong parameter to call aeon (nvidia-backend)
This was referenced Oct 28, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hwlocMemory.cppAfter fixing #75 there was a second compile issue in the nvidia-backend.
I realized that the nvidia aeon and xmr support in the current dev is broken. I used the wrong order for two template arguments and used the monero parameter for aeon. I don't know how I passed my tests (maybe dirty environment)
Tests
I repeated the tests for aeon and monero on a clean environment.