Updated Editor height styles. #395 (1) #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizheming
reviewed
Jul 27, 2017
| @@ -626,7 +626,8 @@ div.pipe:after, .pipe>.half:before, .pipe>.half:after { | |||
| color: #AAA; | |||
| } | |||
| .theme-editor .CodeMirror { | |||
| height: 600px; | |||
| height: calc(100vh - 200px); | |||
There was a problem hiding this comment.
还有别的方法么...这么一改 IE 全跪了？还是说我们现在已经忽略了 IE 了....
lizheming
approved these changes
Jul 27, 2017
| @@ -626,7 +626,8 @@ div.pipe:after, .pipe>.half:before, .pipe>.half:after { | |||
| color: #AAA; | |||
| } | |||
| .theme-editor .CodeMirror { | |||
| height: 600px; | |||
| height: calc(100vh - 200px); | |||
wei
added a commit
to wei/firekylin
that referenced
this pull request
Jul 27, 2017
wei
added a commit
to wei/firekylin
that referenced
this pull request
Jul 27, 2017
Merged
lizheming
pushed a commit
that referenced
this pull request
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if this will work. #395 (1)