Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEM download error when switching between geographic regions #327

Closed
nwagenbrenner opened this issue Feb 4, 2019 · 13 comments
Closed

DEM download error when switching between geographic regions #327

nwagenbrenner opened this issue Feb 4, 2019 · 13 comments
Assignees
@ksshannon
Labels
bug component:gui priority:med severity:med
Milestone
Unplanned

Comments

@nwagenbrenner
Copy link
Member

If you download a DEM from a source outside of the US SRTM region, then attempt to download US SRTM data within the US you get the "Area out of bounds" error. For example, this happened to me when I downloaded a DEM near Adelaide, then attempted to download one from Utah.
@nwagenbrenner nwagenbrenner added this to the Unplanned milestone Feb 4, 2019
@ksshannon ksshannon self-assigned this Feb 4, 2019
@ksshannon
Copy link
Member

I can't reproduce, I downloaded an Adelaide DEM in GMTED, then navigated to Utah and downloaded one. Can you provide a more detailed reproduction?

@nwagenbrenner
Copy link
Member Author

You tried on the master branch? I'll try again and see if I can reproduce it and report back.

@ksshannon
Copy link
Member

Yes, on master. I may have done something different though.

@nwagenbrenner
Copy link
Member Author

I started the GUI, opened the DEM downloader, navigated to Australia, downloaded a GMTED DEM in southern Australia, then navigated back to Idaho, selected an area, changed the data source choice to US SRTM, and clicked download and got this error.

error

Went through these steps 3 times and got this error every time.

@ksshannon
Copy link
Member

ksshannon commented Feb 15, 2019 via email

@ksshannon
Copy link
Member

ksshannon commented Feb 20, 2019 via email

@ksshannon
Copy link
Member

Maybe side-effect of #328 and/or #331? It's possible the sources are mixed http/https. I'm going to have a hard time debugging this if it's win32 only.

@nwagenbrenner
Copy link
Member Author

Happens for me on Linux too.

@nwagenbrenner
Copy link
Member Author

With CPL_DEBUG=ON, I see this when navigate back to the US and try to download an SRTM source near Dillon. Looks like that longitudes are messed up.

WINDNINJA: Checking for containment of POLYGON( (246.85 44.9302, 246.855 44.9302, 246.855 44.928, 246.85 44.928, 246.85 44.9302) ) in /home/natalie/src/windninja/windninja/data/us_srtm_region.shp:

@ksshannon
Copy link
Member

ksshannon commented Feb 20, 2019 via email

nwagenbrenner pushed a commit that referenced this issue Apr 15, 2019
@ksshannon @nwagenbrenner
data/map: Wrap decimal degrees to 0 < x < 360
e03b063 
When navigating east/west, the longitude increases indefinely.  So if
you wrap around the globe three times to the west, you end up at 3 * 360
degrees west.  The fix in 863f70a only
handled the wrap around the date line, not around the world several
times.

[ci skip]

Fixes #327
@nwagenbrenner
Copy link
Member Author

This one is still happening for me in the master branch.

error

@nwagenbrenner nwagenbrenner reopened this Apr 15, 2019
@ksshannon
Copy link
Member

Please try now.

@nwagenbrenner
Copy link
Member Author

Seems good now. Thanks!

nwagenbrenner pushed a commit that referenced this issue Apr 15, 2019
@ksshannon @nwagenbrenner
data/map.htm: handle 180 < x < 360 in map MBR
a5c9a90 
The fix for #327 didn't switch longitudes for the MBR when the values
are 180 < x < 360.  Our services require -180 < x < 180.

Fixes #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksshannon ksshannon

Labels
bug component:gui priority:med severity:med
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@ksshannon @nwagenbrenner