-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smokeview particle colorbar #3767
Comments
I'll take a look at it |
I noticed this as well when working this case. I thought that the crazy numbers were related to the fact that the case was failing due to numerical problems. I also loaded the latest Smokeview, which behaved differently but in a way that I could not nail down. In other words, I would have to go back and reinstall the older version. I did notice that things worked well when I set the particle bounds, and then loaded the particle file. However, if I load the particle file, and then set the bounds, I do not get the right colors. I suspect that the two quantities (droplet temperature and droplet diameter) have similar value ranges, and one might be getting confused with the other. |
this problem is related to there being no particles in a number of the meshes. If you load only meshes 2, 3, 4, 5, 6, 11, 12 and 14 (all others have no particles). you'll see sensible bounds. sensible with a caveat - now I am not sure they are being computed correctly is it possible to set up an fds case where you predefine particles values - say particles in mesh 1 are initialized to 100 C and particles in mesh 2 are defined to 200 C. the particle code in smokeview is complicated. It would be nice verify that it is computing the right bounds. |
I will do this for you. Jason is working various other issues. K |
The following case has particles in meshes 1-7 at temperatures of 100-700 C, respectively. The 8th mesh is empty. The particles fall to the floor so that we can check MPI communication as well.
|
thanks. I'll look at it with smokeview On Thu, Apr 7, 2016 at 11:58 AM, Kevin McGrattan notifications@github.com
Glenn Forney |
update: there were problems with how particle data bounds and particle data values -> colors were computed in cases with multiple meshes. I've fixed the bounds problem and am working on getting the color mapping right. |
Also try loading the particles, then setting the color bounds. I have found this to be a problem. If I set the color bounds first, then load the particles, things work. Also, I don't think the "reload particle file" within the change bounds dialog box is working properly. It seemed to be loading only mesh 1. |
try smokeviews located at I overhauled the way smokeview computes particle bounds and colors. basically the first time you load particles files, smokeview computes and stores (compressed) histograms of particle values. It then uses this information to compute particle bounds. kevin - the "reload particle file" button was broken. It should be working now. let me know if you see something different. for future reference in addition to addressing this problem I also removed code supporting for particle files produced by FDS version 4 and earlier. This cleaned things up quite a bit. let me know if you see any problems . (there were a lot of changes, ~20 commits, so will be surprised you don't come across some hiccups!) |
I tried the case again and everything seems to work nicely. Thanks. |
Running the case in issue 3765 with the current source and using the just released smokeview 6.3.6. Debug in the code shows I am getting reasonable particle diameters, but when I load the particles in smokeview I get diameters colored from -1E9 to 1E9. The same happens for particle temperature.
The text was updated successfully, but these errors were encountered: