Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager: Add back InfoStreamLoggers to buildbitstream related tasks #1292

Merged
merged 2 commits into from Nov 9, 2022

Conversation

davidbiancolin
Copy link
Contributor

In practice i've found it really annoying to have to dig through the logs, which tend proliferate. More over, these tasks tend to fail often and show signs of failing early so i'd rather just get it blasted to stdout as well.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@sagark sagark self-requested a review November 3, 2022 16:45
Copy link
Member

@sagark sagark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff. this addresses: #1271

@davidbiancolin davidbiancolin enabled auto-merge (squash) November 9, 2022 04:07
@davidbiancolin davidbiancolin merged commit 087f340 into main Nov 9, 2022
@davidbiancolin davidbiancolin deleted the readd-infostream-loggers branch November 9, 2022 05:57
nandor pushed a commit to fabianschuiki/firesim that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants