Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimUtils tests #1295

Merged
merged 2 commits into from Nov 10, 2022
Merged

Fix SimUtils tests #1295

merged 2 commits into from Nov 10, 2022

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Nov 10, 2022

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@nandor nandor added the changelog:omit Do not include this PR in the changelog label Nov 10, 2022
@t14916
Copy link
Contributor

t14916 commented Nov 10, 2022

LGTM, Probably request @davidbiancolin for checking over the scala tests. As an FYI scalafmt isn't passing so might still need to reformat the tests.

@davidbiancolin
Copy link
Contributor

make scalafmtAll should do it

Copy link
Contributor

@davidbiancolin davidbiancolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbiancolin
Copy link
Contributor

It's late in europe so i'll just fix this up

@davidbiancolin davidbiancolin enabled auto-merge (squash) November 10, 2022 21:07
@davidbiancolin davidbiancolin merged commit 94ebd71 into main Nov 10, 2022
@davidbiancolin davidbiancolin deleted the fix-tests branch November 10, 2022 23:01
nandor added a commit to fabianschuiki/firesim that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:omit Do not include this PR in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants