Remove raw pointers from bridge port address creation

[nandor]

Minor cleanup to help fix memory leaks and avoid raw pointers.

Macros instantiating bridge parameters are removed in favour of a single macro creating a structure as a value, which is then passed on to constructor and saved in the bridges themselves. With this method, ownership is clear and missing calls to free no longer lead to leaks.

Related PRs / Issues

N/A

UI / API Impact

Changed the *_substruct_create macro to directly instantiate an value containing all ports.

Verilog / AGFI Compatibility

N/A

Contributor Checklist

• Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
• Did you add Scaladoc/docstring/doxygen to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous prints/debugging code?
• Did you state the UI / API impact?
• Did you specify the Verilog / AGFI compatibility impact?

• If applicable, did you regenerate and publicly share default AGFIs?

• If applicable, did you apply the ci:fpga-deploy label?

• If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

• Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
• Did you mark the proper release milestone?
• Did you check whether all relevant Contributor checkboxes have been checked?

[fabianschuiki]

One of the tests seems to break 🤔

I like the sweeping cleanup this does. If we aren't disturbing anyone else's ongoing and uncommitted work on these files, this might be a good thing to land at some point to make everybody's life easier in the future (even if we plan to do some cleanup on the driver side at some point anyway).

[nandor]

A new test was added in the meantime, causing the tests to fail - I'll address it alongside other comments.

[davidbiancolin]

LGTM. Beyond the memory leak change, I think the constness of mmio_addrs is a really positive one.

[davidbiancolin]

In light of CI being disabled, I'm OK force merging this once you manually confirm groupA, B, and chipyard scala tests pass.

[nandor]

The tests mentioned all pass with this change.