Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split project Makefrag into multiple components #1354

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Jan 2, 2023

Project-specific Makefrags are now split into multiple bits. This allows the build flow to first gather all configuration, then define individual rules based on them.

The following makefrags must be present in the folder:

  • config.mk: override configuration variables with project specifics
  • build.mk: define the build rule generating the input FIRRTL and annotations
  • driver.mk: define the configuration for the driver
  • run.mk: define rules to run the simulator binaries.

Related PRs / Issues

UI / API Impact

External projects must split Makefrag into multiple bits.

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@nandor nandor added the changelog:changed Put PR title in 'Changed' section of changelog label Jan 2, 2023
@nandor nandor force-pushed the split-target-agnostic branch 2 times, most recently from 88d39f5 to 1f0609d Compare January 5, 2023 10:51
Base automatically changed from split-target-agnostic to main January 6, 2023 13:54
@nandor nandor force-pushed the split-makefrag branch 5 times, most recently from 0a04120 to b149eba Compare January 9, 2023 13:36
Copy link
Contributor

@davidbiancolin davidbiancolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor name fixes.

sim/Makefile Outdated Show resolved Hide resolved
sim/make/config.mk Outdated Show resolved Hide resolved
sim/make/config.mk Outdated Show resolved Hide resolved
sim/make/config.mk Outdated Show resolved Hide resolved
@nandor nandor enabled auto-merge (squash) January 18, 2023 08:22
@nandor nandor merged commit e5fc4cc into main Jan 18, 2023
@nandor nandor deleted the split-makefrag branch January 18, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Put PR title in 'Changed' section of changelog ci:fpga-deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants