Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loadmem bug in firesim_tsi.cc #1401

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Fix loadmem bug in firesim_tsi.cc #1401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64ea141
Fix bug in fesvr loadmem path
jerryz123 Jan 24, 2023
1b03338
Update sim/firesim-lib/src/main/cc/fesvr/firesim_tsi.h
jerryz123 Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions sim/firesim-lib/src/main/cc/fesvr/firesim_tsi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ class firesim_tsi_t final : public testchip_tsi_t {
void load_mem_write(addr_t addr, size_t nbytes, const void *src) override;
void load_mem_read(addr_t addr, size_t nbytes, void *dst) override;

// This must be exactly the same as hKey.dataBits in the LoadMem widget
// See discussion here: https://github.com/firesim/firesim/pull/1401
// TODO: Avoid hardcoding this value here
size_t chunk_align() override { return 8; }

std::deque<firesim_loadmem_t> loadmem_write_reqs;
std::deque<firesim_loadmem_t> loadmem_read_reqs;
std::deque<char> loadmem_write_data;
Expand Down